GNU bug report logs - #34254
[PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ericbavier <at> centurylink.net
Subject: bug#34254: closed (Re: [bug#34254] [PATCH] build: clean-go: Do
 not warn about *.go files in "test-tmp".)
Date: Fri, 08 Feb 2019 03:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34254: [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34254 <at> debbugs.gnu.org.

-- 
34254: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34254
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 34254-done <at> debbugs.gnu.org
Subject: Re: [bug#34254] [PATCH] build: clean-go: Do not warn about *.go
 files in "test-tmp".
Date: Thu, 7 Feb 2019 21:22:56 -0600

[Message part 3 (text/plain, inline)]

On Wed, 06 Feb 2019 23:04:36 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> ericbavier <at> centurylink.net skribis:
> 
> > From: Eric Bavier <bavier <at> member.fsf.org>
> >
> > * Makefile.am (clean-go): Ignore "test-tmp" directory.  
> 
> Neat, go for it!  This had been annoying me for a while actually…
> 
> Thanks,
> Ludo’.

Pushed to master in 92becc3f15ce196a94274f80ee0b6594774856fa

`~Eric

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".
Date: Tue, 29 Jan 2019 23:08:58 -0600

From: Eric Bavier <bavier <at> member.fsf.org>

* Makefile.am (clean-go): Ignore "test-tmp" directory.
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 0590c51519..fec9800ce7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -318,7 +318,7 @@ nobase_nodist_guileobject_DATA = $(GOBJECTS)
 # Handy way to remove the .go files without removing all the rest.
 clean-go:
 	-$(RM) -f $(GOBJECTS)
-	@find . -name '*.go' -print | \
+	@find . -path ./test-tmp -prune -o -name '*.go' -print | \
 	  if test -t 1; then \
 	    xargs -r echo -e "\033[31mwarning:\033[0m stray .go files:"; \
 	  else \
-- 
2.20.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.