GNU bug report logs - #3408
customize-face not working: seems to apply to frame-face

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: David Reitter <david.reitter <at> gmail.com>
Subject: bug#3210: closed (Re: bug#3408: bug#3210: face customization
 fails after set-face-attribute)
Date: Sun, 25 Nov 2012 05:07:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#3408: face customization fails after set-face-attribute

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 3210 <at> debbugs.gnu.org.

-- 
3408: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3408
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 'David Reitter' <david.reitter <at> gmail.com>, 3210 <at> debbugs.gnu.org,
	3408-done <at> debbugs.gnu.org
Subject: Re: bug#3408: bug#3210: face customization fails after
	set-face-attribute
Date: Sun, 25 Nov 2012 13:04:32 +0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

> Bug #3408 is a _regression_, and it has not been fixed.
> A regression is certainly NOT `notabug'.

I disagree that this is a bug.  I have now taken another look at the
code, and my earlier conclusion stands.  Modifications to internal Lisp
faces (via set-face-attribute) take precedence over the effect of face
specs, so the behavior is working as intended and as documented
(including in the docstring of set-face-attribute).

The trunk now contains a change to face-spec-set which allows it to be
more easily called from Lisp code to override defface specs.  If you
want to modify faces from Lisp, use that rather than set-face-attribute.

Don't re-open this bug based on uninformed opinion.  Thanks.

[Message part 3 (message/rfc822, inline)]

From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: face customization fails after set-face-attribute
Date: Mon, 4 May 2009 16:04:35 -0400

Emacs -Q

(set-face-attribute 'default nil
		    :height 130
		    :family "Lucida Grande")
;; modifies default face

(customize-face 'default)
;; switch back manually to Monaco and "set for current session"

(make-frame-command)  ;; C-x 5 2
;; the new frame is shown in Lucida.  Why?


Upon inspection of some code, it appears unclear why `face-spec-set'  
iterates over all frame faces and sets the new spec there, but doesn't  
set the right property to set the face for future frames in case for- 
defface is t.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.