GNU bug report logs - #3410
tar mode fails to open many valid files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3410 in the body.
You can then email your comments to 3410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
To: submit <at> debbugs.gnu.org
Subject: tar mode fails to open many valid files
Date: Thu, 28 May 2009 17:05:14 +0300

When I open a 'tar.gz' file in Emacs, it quite often fails with a
message similar to:

    File mode specification error: (error
    "ntWorkbookBuilder.SheetRecordCollectingListener.html\"
    title=\"class in org.apache.poi.hssf.eventuserm has size
    -137265917 - corrupted")

E.g. file at

    http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz

exhibits this error.  It can be extracted without problems with 'tar
-xzf ...' at command line, so it must be a bug in Emacs' tar mode.
Maybe it is too strict or doesn't handle some extension properly.

Paul

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Cc: 3410 <at> debbugs.gnu.org, submit <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Fri, 29 May 2009 12:16:04 -0400

> http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz

> exhibits this error.

It opens just fine for me.  Are you using Emacs-22 rather than the
pretest, by any chance?


        Stefan

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 3410 <at> debbugs.gnu.org, submit <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Mon, 1 Jun 2009 11:51:24 +0300

Stefan Monnier wrote:
> > http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz
> 
> > exhibits this error.
> 
> It opens just fine for me.  Are you using Emacs-22 rather than the
> pretest, by any chance?

No, M-x version reports GNU Emacs 23.0.94.1 (i686-pc-linux-gnu, GTK+
Version 2.14.4).  Just checked, I get the error also with 'emacs -q'.

Paul

Message #30 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Cc: 3410 <at> debbugs.gnu.org, submit <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Wed, 03 Jun 2009 15:42:12 -0400

>> > http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz
>> 
>> > exhibits this error.
>> 
>> It opens just fine for me.  Are you using Emacs-22 rather than the
>> pretest, by any chance?

> No, M-x version reports GNU Emacs 23.0.94.1 (i686-pc-linux-gnu, GTK+
> Version 2.14.4).  Just checked, I get the error also with 'emacs -q'.

I cannot reproduce it with "emacs -Q
~/tmp/poi-bin-3.5-beta5-20090219.tar.gz" (on amd64 with Gtk as well).
Other than the "-Q" vs "-q" (i.e. if you have some site-start.el or
default.el that could interfere) I can't think of anything that could
explain the difference.


        Stefan

Message #40 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 3410 <at> debbugs.gnu.org, submit <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Thu, 4 Jun 2009 11:32:25 +0300

Stefan Monnier wrote:
> >> > http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz
> >> 
> >> > exhibits this error.
> >> 
> >> It opens just fine for me.  Are you using Emacs-22 rather than the
> >> pretest, by any chance?
> 
> > No, M-x version reports GNU Emacs 23.0.94.1 (i686-pc-linux-gnu, GTK+
> > Version 2.14.4).  Just checked, I get the error also with 'emacs -q'.
> 
> I cannot reproduce it with "emacs -Q
> ~/tmp/poi-bin-3.5-beta5-20090219.tar.gz" (on amd64 with Gtk as well).
> Other than the "-Q" vs "-q" (i.e. if you have some site-start.el or
> default.el that could interfere)

I tried with 'emacs -Q' and get the same result:

File poi-bin-3.5-beta5-20090219.tar.gz is large (19MB), really open? (y or n) 
uncompressing poi-bin-3.5-beta5-20090219.tar.gz...done
Parsing tar file...
File mode specification error: (error "ntWorkbookBuilder.SheetRecordCollectingListener.html\" title=\"class in org.apache.poi.hssf.eventuserm has size -137265917 - corrupted")

> I can't think of anything that could explain the difference.

The only difference can I see is CPU architecture: you have amd64, but
I have a 32-bit system.

Paul

Message #50 received at 3410 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Cc: 3410 <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Thu, 04 Jun 2009 12:26:03 -0400

> I tried with 'emacs -Q' and get the same result:

> File poi-bin-3.5-beta5-20090219.tar.gz is large (19MB), really open? (y or n) 
> uncompressing poi-bin-3.5-beta5-20090219.tar.gz...done
> Parsing tar file...

Same thing until here.

> File mode specification error: (error "ntWorkbookBuilder.SheetRecordCollectingListener.html\" title=\"class in org.apache.poi.hssf.eventuserm has size -137265917 - corrupted")

I believe I could now reproduce it, but only if I use url-handler-mode
and download the file directly from Emacs.

I.e. it works fine with
   emacs -Q ~/tmp/poi-bin-3.5-beta5-20090219.tar.gz
but shows your problem with
   emacs -Q -f url-handler-mode; C-x C-f http://.../poi... RET


-- Stefan

Message #55 received at 3410-close <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Cc: 3410-close <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Thu, 04 Jun 2009 16:48:56 -0400

> I.e. it works fine with
>    emacs -Q ~/tmp/poi-bin-3.5-beta5-20090219.tar.gz
> but shows your problem with
>    emacs -Q -f url-handler-mode; C-x C-f http://.../poi... RET

In the end you were right, and I have no idea how I managed to get the
above results.  url-handler-mode makes no difference, and the 64bit
thingy makes a difference (it somehow hides the bug, so it doesn't
signal an error but instead misinterprets the middle of the tar file,
while the beginning and the end are still just fine, so my cursory check
didn't see the corruption).

I've just installed the patch below, which should fix the problem,


        Stefan


--- tar-mode.el.~1.139.~	2009-03-20 16:24:31.000000000 -0400
+++ tar-mode.el	2009-06-04 16:41:49.000000000 -0400
@@ -276,7 +276,10 @@
             (setq link-p 5))            ; directory
 
         (if (and (equal name "././@LongLink")
-                 (equal magic-str "ustar ")) ;OLDGNU_MAGIC.
+                 ;; Supposedly @LongLink is only used for GNUTAR
+                 ;; format (i.e. "ustar ") but some POSIX Tar files
+                 ;; (with "ustar\0") have been seen using it as well.
+                 (member magic-str '("ustar " "ustar\0")))
             ;; This is a GNU Tar long-file-name header.
             (let* ((size (tar-parse-octal-integer
                           string tar-size-offset tar-time-offset))

Message #58 received at 3410 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Cc: 3410 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Thu, 04 Jun 2009 20:45:45 -0400

Paul Pogonyshev wrote:

> The only difference can I see is CPU architecture: you have amd64, but
> I have a 32-bit system.

Dead on. I normally use an x86_64 emacs and could see no problem; I
rebuilt on i386 and now I see it too.

Message #63 received at 3410 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 3410 <at> debbugs.gnu.org
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Wed, 1 Jul 2009 18:13:41 +0300

Not sure if it is possible to reopen a bug, but I have simliar
problems with another tarball:

    http://sunet.dl.sourceforge.net/sourceforge/hibernate/hibernate-distribution-3.3.2.GA-dist.tar.gz

    File hibernate-distribution-3.3.2.GA-dist.tar.gz is large (39MB), really open? (y or n) 
    uncompressing hibernate-distribution-3.3.2.GA-dist.tar.gz...done
    Parsing tar file...
    File mode specification error: (error "package org.hibernate.test.collection.idbag;

Note that the original tarball now opens fine, so I do have the bugfix
compiled in.  Again, this is on a 32-bit system.

Paul

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.