GNU bug report logs - #3408
customize-face not working: seems to apply to frame-face

Previous Next

Package: emacs;

Reported by: David Reitter <david.reitter <at> gmail.com>

Date: Thu, 28 May 2009 00:50:04 UTC

Severity: normal

Tags: notabug

Merged with 3210

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: David Reitter <david.reitter <at> gmail.com>
Subject: bug#3408: closed (Re: bug#3408: bug#3210: face customization
 fails after set-face-attribute)
Date: Sun, 25 Nov 2012 05:07:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#3408: customize-face not working: seems to apply to frame-face

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 3408 <at> debbugs.gnu.org.

-- 
3408: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3408
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 'David Reitter' <david.reitter <at> gmail.com>, 3210 <at> debbugs.gnu.org,
	3408-done <at> debbugs.gnu.org
Subject: Re: bug#3408: bug#3210: face customization fails after
	set-face-attribute
Date: Sun, 25 Nov 2012 13:04:32 +0800
"Drew Adams" <drew.adams <at> oracle.com> writes:

> Bug #3408 is a _regression_, and it has not been fixed.
> A regression is certainly NOT `notabug'.

I disagree that this is a bug.  I have now taken another look at the
code, and my earlier conclusion stands.  Modifications to internal Lisp
faces (via set-face-attribute) take precedence over the effect of face
specs, so the behavior is working as intended and as documented
(including in the docstring of set-face-attribute).

The trunk now contains a change to face-spec-set which allows it to be
more easily called from Lisp code to override defface specs.  If you
want to modify faces from Lisp, use that rather than set-face-attribute.

Don't re-open this bug based on uninformed opinion.  Thanks.

[Message part 3 (message/rfc822, inline)]
From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: customize-face not working: seems to apply to frame-face
Date: Wed, 27 May 2009 20:40:37 -0400
Emacs -Q

(set-face-attribute 'default nil
		    :height 130
		    :family "Lucida Grande")
;; switches default face

(customize-face 'default)
;; switch back manually to Monaco

(make-frame-command)  ;; C-x 5 2
;; the new frame is shown in the Lucida face.  Why?

The same thing works as I would expect in Emacs 22.  I would generally  
assume that `customize-face' applies to faces in future frames as well.

If this is no bug, I think an entry in NEWS under "Faces" would be  
appropriate....

Cc'ing Bob Halley who isolated this (but doesn't think it's a bug).


PS.: text-scale-mode is mentioned twice in NEWS.



This bug report was last modified 12 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.