GNU bug report logs - #33669
26.1; Buffer-menu-mode bad UX

Previous Next

Package: emacs;

Reported by: Devon Sean McCullough <Emacs-Hacker2018 <at> jovi.net>

Date: Sat, 8 Dec 2018 02:08:02 UTC

Severity: normal

Found in version 26.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #19 received at 33669-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Devon Sean McCullough <Emacs-Hacker2018 <at> jovi.net>
Cc: 33669-done <at> debbugs.gnu.org
Subject: Re: bug#33669: 26.1; Buffer-menu-mode bad UX
Date: Sat, 12 Jan 2019 13:53:28 +0200
> From: Devon Sean McCullough <Emacs-Hacker2018 <at> jovi.net>
> Date: Sat, 5 Jan 2019 10:36:22 -0500
> 
> > On Jan 5, 2019, at 3:44 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Ping!  Ping!  Devon, could you please try the proposed fix?
> 
> The original and patched versions both look problematic.  Instead, I had good results with
> 
> --- old/buff-menu.el	2019-01-05 10:26:45.000000000 -0500
> +++ new/buff-menu.el	2019-01-05 10:27:23.000000000 -0500
> @@ -475,10 +475,10 @@
>  			   (save-buffer))
>  			 (tabulated-list-set-col 2 " " t))
>  		     (error (warn "Error saving %s" buffer))))
> -		 (if delete
> -		     (unless (eq buffer (current-buffer))
> -		       (kill-buffer buffer)
> -		       (tabulated-list-delete-entry))
> +		 (if (and delete
> +			  (not (eq buffer (current-buffer)))
> +                          (kill-buffer buffer))
> +                     (tabulated-list-delete-entry)
>  		   (forward-line 1)))))))))
>  
>  (defun Buffer-menu-select ()
> 

Thanks, pushed to the emacs-26 branch.




This bug report was last modified 6 years and 188 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.