GNU bug report logs - #33567
Syntactic fontification of diff hunks

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Sat, 1 Dec 2018 22:13:02 UTC

Severity: wishlist

Tags: patch

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #151 received at 33567 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: 33567 <at> debbugs.gnu.org
Subject: Re: bug#33567: Syntactic fontification of diff hunks
Date: Wed, 26 Dec 2018 02:43:08 +0200
On 21.12.2018 0:17, Juri Linkov wrote:

> But please see in https://debbugs.gnu.org/10181#68
> why red and green colors are not symmetrical and
> how is was wrong on GitHub.

Thanks! (TBC in another email).

> Your proposed new colors for added/removed are the same that are used
> GitHub/GitLab, so this should be a good change.

Now pushed, thank you.

> While at it, please also tone down file/hunk header colors:
> diff-header from grey80 to grey90 and
> diff-file-header from grey70 to grey80

I see you have done that yourself, looks good.




This bug report was last modified 6 years and 194 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.