GNU bug report logs - #33568
27.0.50; Failing secrets tests on Cygwin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33568 in the body.
You can then email your comments to 33568 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 27.0.50; Failing secrets tests on Cygwin
Date: Sat, 1 Dec 2018 23:02:57 +0000

[Message part 1 (text/plain, inline)]

Two of the secrets tests fail on Cygwin (at least in my normal working
environment) because there is no "Login" collection.  Not knowing
anything about this, I'm inclined to take the easy way out, as in the
attached patch.  Is there a better way of handling it?

Ken


In GNU Emacs 27.0.50 (build 6, x86_64-pc-cygwin, GTK+ Version 3.22.28)
  of 2018-12-01 built on moufang2
Repository revision: 070ef95c1007cb3d54e04bc337d9fb5463912cc1
Repository branch: master
Windowing system distributor 'The Cygwin/X Project', version 11.0.12002000

[0001-Fix-secrets-tests-on-Cygwin.patch (text/plain, attachment)]

Message #10 received at 33568 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 33568 <at> debbugs.gnu.org
Subject: Re: bug#33568: 27.0.50; Failing secrets tests on Cygwin
Date: Sun, 02 Dec 2018 10:17:34 +0100

Ken Brown <kbrown <at> cornell.edu> writes:

Hi Ken,

> Two of the secrets tests fail on Cygwin (at least in my normal working
> environment) because there is no "Login" collection.  Not knowing
> anything about this, I'm inclined to take the easy way out, as in the
> attached patch.  Is there a better way of handling it?

Thanks for the report. I don't know whether there is a better way; let's
explore your system.

What do you get if you call (secrets-list-collections) ? (Maybe you must
load the library `secrets' first)

> Ken

Best regards, Michael.

Message #13 received at 33568 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: "33568 <at> debbugs.gnu.org" <33568 <at> debbugs.gnu.org>
Subject: Re: bug#33568: 27.0.50; Failing secrets tests on Cygwin
Date: Sun, 2 Dec 2018 12:23:55 +0000

On 12/2/2018 4:17 AM, Michael Albinus wrote:

Hi Michael,

> Thanks for the report. I don't know whether there is a better way; let's
> explore your system.
> 
> What do you get if you call (secrets-list-collections) ? (Maybe you must
> load the library `secrets' first)

(load "secrets")
t

(secrets-list-collections)
("session")

Ken

Message #16 received at 33568 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: "33568 <at> debbugs.gnu.org" <33568 <at> debbugs.gnu.org>
Subject: Re: bug#33568: 27.0.50; Failing secrets tests on Cygwin
Date: Sun, 02 Dec 2018 13:36:02 +0100

Ken Brown <kbrown <at> cornell.edu> writes:

> Hi Michael,

Hi Ken,

> (secrets-list-collections)
> ("session")

Hmm. There's no "Login" collection, indeed. Nor any other collection but
the temporary "session" collection. I will see whether I could
reproduce the problem locally.

> Ken

Best regards, Michael.

Message #19 received at 33568 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: "33568 <at> debbugs.gnu.org" <33568 <at> debbugs.gnu.org>
Subject: Re: bug#33568: 27.0.50; Failing secrets tests on Cygwin
Date: Wed, 12 Dec 2018 10:59:15 +0100

Ken Brown <kbrown <at> cornell.edu> writes:

> Hi Michael,

Hi Ken,

sorry for the delay. Finally, I found a machine running cygwin for my tests.

>> Thanks for the report. I don't know whether there is a better way; let's
>> explore your system.
>> 
>> What do you get if you call (secrets-list-collections) ? (Maybe you must
>> load the library `secrets' first)
>
> (load "secrets")
> t
>
> (secrets-list-collections)
> ("session")

Hmm, same here, when using the GNOME desktop. I always thought that the
"login" keyring exist per default, but it doesn't. Maybe this is due to
different invocations od gnome-keyring-daemon. On my Ubuntu 18.10
system, it is

--8<---------------cut here---------------start------------->8---
$ ps -eaf | grep gnome-keyring
albinus   6340     1  0 Dec04 ?        00:02:03 /usr/bin/gnome-keyring-daemon --daemonize --login
--8<---------------cut here---------------end--------------->8---

OTOH, on cygwin I see

--8<---------------cut here---------------start------------->8---
$ ps -eaf | grep gnome-keyring
albinmic    5676       1 ?        16:09:48 /usr/bin/gnome-keyring-daemon
--8<---------------cut here---------------end--------------->8---

I can create the "login" keyring interactively, via seahorse. But this
doesn't count.

So I have removed the respective checks in secrets-tests.el, they are
not important. Could you pls check, whether this works for you?

> Ken

Best regards, Michael.

Message #26 received at 33568-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: "33568 <at> debbugs.gnu.org" <33568-done <at> debbugs.gnu.org>
Subject: Re: bug#33568: 27.0.50; Failing secrets tests on Cygwin
Date: Wed, 12 Dec 2018 18:28:19 +0000

On 12/12/2018 4:59 AM, Michael Albinus wrote:
> So I have removed the respective checks in secrets-tests.el, they are
> not important. Could you pls check, whether this works for you?

Thanks, Michael.  All tests pass now.  Closing.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.