GNU bug report logs - #33494
25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33494: closed (25.2; vc-bzr-expanded-log-entry does not honor
 vc-bzr-log-switches)
Date: Sat, 08 Dec 2018 09:37:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 08 Dec 2018 11:35:44 +0200
with message-id <83zhtg4az3.fsf <at> gnu.org>
and subject line Re: bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
has caused the debbugs.gnu.org bug report #33494,
regarding 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33494: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33494
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Steven De Herdt <steven.deherdt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
Date: Sat, 24 Nov 2018 23:57:57 +0100

Hello.

In Bzr-Log-View, pressing RET brings up more info about a certain
revision, but this expanded log entry does not honor customized switches
for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
switches just like vc-bzr-print-log does:

(defun vc-bzr-expanded-log-entry (revision)
  (with-temp-buffer
    (apply 'vc-bzr-command "log" t nil nil
     (append
      (list "--long" (format "-r%s" revision))
      (if (stringp vc-bzr-log-switches)
          (list vc-bzr-log-switches)
        vc-bzr-log-switches)))
    (goto-char (point-min))
    (when (looking-at "^-+\n")
      ;; Indent the expanded log entry.
      (indent-region (match-end 0) (point-max) 2)
      (buffer-substring (match-end 0) (point-max)))))

I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'...

Thanks for you work on Emacs!
-Steven

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steven De Herdt <steven.deherdt <at> gmail.com>
Cc: 33494-done <at> debbugs.gnu.org
Subject: Re: bug#33494: 25.2;
 vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
Date: Sat, 08 Dec 2018 11:35:44 +0200

> From: Steven De Herdt <steven.deherdt <at> gmail.com>
> Date: Sat, 24 Nov 2018 23:57:57 +0100
> 
> In Bzr-Log-View, pressing RET brings up more info about a certain
> revision, but this expanded log entry does not honor customized switches
> for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
> switches just like vc-bzr-print-log does:

Thanks, pushed to the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.