GNU bug report logs - #33494
25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches

Previous Next

Package: emacs;

Reported by: Steven De Herdt <steven.deherdt <at> gmail.com>

Date: Sat, 24 Nov 2018 23:46:01 UTC

Severity: normal

Found in version 25.2

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33494 in the body.
You can then email your comments to 33494 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#33494; Package emacs. (Sat, 24 Nov 2018 23:46:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Steven De Herdt <steven.deherdt <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 24 Nov 2018 23:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steven De Herdt <steven.deherdt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
Date: Sat, 24 Nov 2018 23:57:57 +0100

Hello.

In Bzr-Log-View, pressing RET brings up more info about a certain
revision, but this expanded log entry does not honor customized switches
for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
switches just like vc-bzr-print-log does:

(defun vc-bzr-expanded-log-entry (revision)
  (with-temp-buffer
    (apply 'vc-bzr-command "log" t nil nil
     (append
      (list "--long" (format "-r%s" revision))
      (if (stringp vc-bzr-log-switches)
          (list vc-bzr-log-switches)
        vc-bzr-log-switches)))
    (goto-char (point-min))
    (when (looking-at "^-+\n")
      ;; Indent the expanded log entry.
      (indent-region (match-end 0) (point-max) 2)
      (buffer-substring (match-end 0) (point-max)))))

I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'...

Thanks for you work on Emacs!
-Steven
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sat, 08 Dec 2018 09:37:01 GMT) Full text and rfc822 format available.
Notification sent to Steven De Herdt <steven.deherdt <at> gmail.com>:
bug acknowledged by developer. (Sat, 08 Dec 2018 09:37:02 GMT) Full text and rfc822 format available.

Message #10 received at 33494-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steven De Herdt <steven.deherdt <at> gmail.com>
Cc: 33494-done <at> debbugs.gnu.org
Subject: Re: bug#33494: 25.2;
 vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
Date: Sat, 08 Dec 2018 11:35:44 +0200

> From: Steven De Herdt <steven.deherdt <at> gmail.com>
> Date: Sat, 24 Nov 2018 23:57:57 +0100
> 
> In Bzr-Log-View, pressing RET brings up more info about a certain
> revision, but this expanded log entry does not honor customized switches
> for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
> switches just like vc-bzr-print-log does:

Thanks, pushed to the master branch.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 05 Jan 2019 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 219 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.