GNU bug report logs - #33494
25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches

Previous Next

Package: emacs;

Reported by: Steven De Herdt <steven.deherdt <at> gmail.com>

Date: Sat, 24 Nov 2018 23:46:01 UTC

Severity: normal

Found in version 25.2

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steven De Herdt <steven.deherdt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
Date: Sat, 24 Nov 2018 23:57:57 +0100

Hello.

In Bzr-Log-View, pressing RET brings up more info about a certain
revision, but this expanded log entry does not honor customized switches
for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
switches just like vc-bzr-print-log does:

(defun vc-bzr-expanded-log-entry (revision)
  (with-temp-buffer
    (apply 'vc-bzr-command "log" t nil nil
     (append
      (list "--long" (format "-r%s" revision))
      (if (stringp vc-bzr-log-switches)
          (list vc-bzr-log-switches)
        vc-bzr-log-switches)))
    (goto-char (point-min))
    (when (looking-at "^-+\n")
      ;; Indent the expanded log entry.
      (indent-region (match-end 0) (point-max) 2)
      (buffer-substring (match-end 0) (point-max)))))

I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'...

Thanks for you work on Emacs!
-Steven
This bug report was last modified 6 years and 222 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.