GNU bug report logs - #33460
24.4; Eshell histfile symlinks not followed

Previous Next

Package: emacs;

Reported by: Philip Hudson <phil.hudson <at> iname.com>

Date: Wed, 21 Nov 2018 23:27:02 UTC

Severity: minor

Tags: patch

Found in version 24.4

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Philip Hudson <phil.hudson <at> iname.com>
To: 33460 <at> debbugs.gnu.org
Subject: bug#33460: 24.4; Eshell histfile symlinks not followed
Date: Wed, 21 Nov 2018 23:09:16 +0000
[Message part 1 (text/plain, inline)]
If the file named by the value of option `eshell-history-file-name' is
a symbolic link, then it will be replaced and overwritten instead. It
should be dereferenced (followed) first, and its target file should be
replaced and overwritten.

The attached patch uses function `file-truename' to fix this. The
patch was made using source cloned from git savannah HEAD today, which
I think is version 26.1.90, based on ChangeLog.3 in the cloned repo.



In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5)
of 2017-09-12 on hullmann, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11604000
System Description: LMDE 2 Betsy


-- 
Phil Hudson                  http://hudson-it.ddns.net
Pretty Good Privacy (PGP) ID: 0x4E482F85
[eshellResolveHistFile.patch (text/x-patch, attachment)]

This bug report was last modified 6 years and 246 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.