GNU bug report logs - #33460
24.4; Eshell histfile symlinks not followed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33460 in the body.
You can then email your comments to 33460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Hudson <phil.hudson <at> iname.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4; Eshell histfile symlinks not followed
Date: Wed, 21 Nov 2018 23:09:16 +0000

[Message part 1 (text/plain, inline)]

If the file named by the value of option `eshell-history-file-name' is
a symbolic link, then it will be replaced and overwritten instead. It
should be dereferenced (followed) first, and its target file should be
replaced and overwritten.

The attached patch uses function `file-truename' to fix this. The
patch was made using source cloned from git savannah HEAD today, which
I think is version 26.1.90, based on ChangeLog.3 in the cloned repo.



In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5)
of 2017-09-12 on hullmann, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11604000
System Description: LMDE 2 Betsy


-- 
Phil Hudson                  http://hudson-it.ddns.net
Pretty Good Privacy (PGP) ID: 0x4E482F85

[eshellResolveHistFile.patch (text/x-patch, attachment)]

Message #10 received at 33460-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Hudson <phil.hudson <at> iname.com>
Cc: 33460-done <at> debbugs.gnu.org
Subject: Re: bug#33460: 24.4; Eshell histfile symlinks not followed
Date: Sat, 08 Dec 2018 11:15:27 +0200

> From: Philip Hudson <phil.hudson <at> iname.com>
> Date: Wed, 21 Nov 2018 23:09:16 +0000
> 
> If the file named by the value of option `eshell-history-file-name' is
> a symbolic link, then it will be replaced and overwritten instead. It
> should be dereferenced (followed) first, and its target file should be
> replaced and overwritten.
> 
> The attached patch uses function `file-truename' to fix this. The
> patch was made using source cloned from git savannah HEAD today, which
> I think is version 26.1.90, based on ChangeLog.3 in the cloned repo.

Thanks, pushed to the master branch, to appear in Emacs 27.1.

Please in the future provide a ChangeLog-style commit log entry for
your changes; see CONTRIBUTE for the details.

Also, user-visible behavior changes need to be called out in NEWS, and
if necessary also in the relevant Texinfo manual(s).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.