GNU bug report logs - #33284
[PATCH] python: Honor '--cores=...' in tests.

Previous Next

Package: guix-patches;

Reported by: Eric Bavier <ericbavier <at> centurylink.net>

Date: Tue, 6 Nov 2018 02:27:01 UTC

Severity: normal

Tags: patch

Done: Eric Bavier <ericbavier <at> centurylink.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33284: closed ([PATCH] python: Honor '--cores=...' in tests.)
Date: Sat, 17 Nov 2018 06:46:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 17 Nov 2018 00:45:15 -0600
with message-id <20181117004515.1111b65a <at> centurylink.net>
and subject line Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
has caused the debbugs.gnu.org bug report #33284,
regarding [PATCH] python: Honor '--cores=...' in tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33284: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33284
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eric Bavier <ericbavier <at> centurylink.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] python: Honor '--cores=...' in tests.
Date: Mon, 5 Nov 2018 20:23:44 -0600
[Message part 3 (text/plain, inline)]
Hello Guix,

I noticed building 'python-minimal' that its tests seemed to have poor
memory performance, i.e. using *a lot* of RAM.  I thought maybe
dropping --cores=... would help, but it did not; the tests use all
available cores by default.  The attached patch fixes this issue,
though, the package still uses all cores while building some extension
libraries.

I suppose this patch would go to core-updates?

Cheers,
`~Eric
[0001-python-Honor-cores-.-in-tests.patch (text/x-patch, attachment)]
[Message part 5 (application/pgp-signature, inline)]
[Message part 6 (message/rfc822, inline)]
From: Eric Bavier <ericbavier <at> centurylink.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>, 33284-close <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Sat, 17 Nov 2018 00:45:15 -0600
[Message part 7 (text/plain, inline)]
On Tue, 06 Nov 2018 17:00:01 +0100
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Eric Bavier <ericbavier <at> centurylink.net> writes:
> 
> > Hello Mathieu,
> >
> > On Tue, 6 Nov 2018 14:07:47 +0900
> > Mathieu Othacehe <m.othacehe <at> gmail.com> wrote:
> >  
> >> Hi Eric,
> >> 
> >> Your patch seems go to me, even if I think the root cause of your problem
> >> is fixed by:
> >> 
> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33186#26
> >> 
> >> I think that both could be applied to core-updates.  
> >
> > Thanks for the link; it looks like it should help.  But, yes, I think
> > both can be applied.  
> 
> Note that the broken test has already been removed on 'core-updates'.
> 
> Eric: can you push a 'python-updates' branch?  I wonder if we have time
> for a "half-rebuild" before the next 'core-updates' round; I've got some
> other heavy-impact patches in my pipeline (Glib, Cairo, ++).
> 
> The patch LGTM.

I've pushed this to the core-updates-next branch in commit
5b01b6034aeab32a5011c5757f18bd9772d3497d

`~Eric
[Message part 8 (application/pgp-signature, inline)]

This bug report was last modified 6 years and 272 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.