GNU bug report logs - #33283
[PATCH] gnu: Add python-pyelftools.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33283 in the body.
You can then email your comments to 33283 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-pyelftools.
Date: Mon, 05 Nov 2018 13:29:02 -0800

[Message part 1 (text/plain, inline)]

* gnu/packages/python.scm (python-pyelftools):
  New public variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 54ea0caac..c553ab319 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10578,6 +10578,29 @@ useful as a validator for JSON data.")
 (define-public python2-validictory
   (package-with-python2 python-validictory))
 
+(define-public python-pyelftools
+  (package
+    (name "python-pyelftools")
+    (version "0.25")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyelftools" version))
+       (sha256
+        (base32
+         "090vdksbz341f7ljvr0zswblw4lspa8qaiikzyjkf318arpxmil9"))))
+    (build-system python-build-system)
+    ;; Test suite requires python-setuptools
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page
+     "https://github.com/eliben/pyelftools")
+    (synopsis
+     "Library for analyzing ELF files and DWARF debugging information")
+    (description
+     "Library for analyzing ELF files and DWARF debugging information")
+    (license license:public-domain)))
+
 (define-public python-pyev
   (package
     (name "python-pyev")
-- 
2.19.1

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 33283 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 33283 <at> debbugs.gnu.org
Subject: Re: [bug#33283] [PATCH] gnu: Add python-pyelftools.
Date: Mon, 05 Nov 2018 23:58:49 +0100

Hello!

Vagrant Cascadian <vagrant <at> debian.org> skribis:

> * gnu/packages/python.scm (python-pyelftools):
>   New public variable.

[...]

> +    (home-page
> +     "https://github.com/eliben/pyelftools")
> +    (synopsis
> +     "Library for analyzing ELF files and DWARF debugging information")
> +    (description
> +     "Library for analyzing ELF files and DWARF debugging information")

Could you expound the description a bit?  (See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.)

Otherwise LGTM.

TIA!

Ludo’.

Message #11 received at 33283 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33283 <at> debbugs.gnu.org
Subject: Re: [bug#33283] [PATCH] gnu: Add python-pyelftools.
Date: Tue, 06 Nov 2018 12:56:42 -0800

[Message part 1 (text/plain, inline)]

On 2018-11-05, Ludovic Courtès <ludo <at> gnu.org> wrote:
> Hello!
>
> Vagrant Cascadian <vagrant <at> debian.org> skribis:
>
>> * gnu/packages/python.scm (python-pyelftools):
>>   New public variable.
>
> [...]
>
>> +    (home-page
>> +     "https://github.com/eliben/pyelftools")
>> +    (synopsis
>> +     "Library for analyzing ELF files and DWARF debugging information")
>> +    (description
>> +     "Library for analyzing ELF files and DWARF debugging information")
>
> Could you expound the description a bit?  (See
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.)

Updated patch attached with an updated synopsis and description,
attempting to follow the mentioned guidelines.

live well,
  vagrant

[0001-gnu-Add-python-pyelftools.patch (text/x-diff, inline)]

From ee20fe1b8e0ecb1fb706b7929af5e4bb63843ff5 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Mon, 5 Nov 2018 19:36:57 +0000
Subject: [PATCH] gnu: Add python-pyelftools.

* gnu/packages/python.scm (python-pyelftools):
  New public variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 54ea0caac..83a62532b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10578,6 +10578,31 @@ useful as a validator for JSON data.")
 (define-public python2-validictory
   (package-with-python2 python-validictory))
 
+(define-public python-pyelftools
+  (package
+    (name "python-pyelftools")
+    (version "0.25")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyelftools" version))
+       (sha256
+        (base32
+         "090vdksbz341f7ljvr0zswblw4lspa8qaiikzyjkf318arpxmil9"))))
+    (build-system python-build-system)
+    ;; Test suite requires python-setuptools
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page
+     "https://github.com/eliben/pyelftools")
+    (synopsis
+     "Analyze binary and library file information")
+    (description "This Python Library provides interfaces for parsing and
+analyzing two binary and library file formats; the Executable and Linking
+Format- ELF, and debugging information in the Debugging With Attributed
+Record Format- DWARF.")
+    (license license:public-domain)))
+
 (define-public python-pyev
   (package
     (name "python-pyev")
-- 
2.11.0

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 33283-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 33283-done <at> debbugs.gnu.org
Subject: Re: [bug#33283] [PATCH] gnu: Add python-pyelftools.
Date: Wed, 07 Nov 2018 22:04:43 +0100

[Message part 1 (text/plain, inline)]

Hi Vagrant,

Vagrant Cascadian <vagrant <at> debian.org> skribis:

> From ee20fe1b8e0ecb1fb706b7929af5e4bb63843ff5 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant <at> debian.org>
> Date: Mon, 5 Nov 2018 19:36:57 +0000
> Subject: [PATCH] gnu: Add python-pyelftools.
>
> * gnu/packages/python.scm (python-pyelftools):
>   New public variable.

Applied with extra nitpicking below.  ;-)

Thank you!

Ludo’.

[Message part 2 (text/x-patch, inline)]

--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10597,10 +10597,10 @@ useful as a validator for JSON data.")
      "https://github.com/eliben/pyelftools")
     (synopsis
      "Analyze binary and library file information")
-    (description "This Python Library provides interfaces for parsing and
+    (description "This Python library provides interfaces for parsing and
 analyzing two binary and library file formats; the Executable and Linking
-Format- ELF, and debugging information in the Debugging With Attributed
-Record Format- DWARF.")
+Format (ELF), and debugging information in the Debugging With Attributed
+Record Format (DWARF).")
     (license license:public-domain)))
 
 (define-public python-pyev

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.