GNU bug report logs - #33059
[PATCH 00/10] Add the FEniCS Project

Previous Next

Package: guix-patches;

Reported by: Paul Garlick <pgarlick <at> tourbillion-technology.com>

Date: Tue, 16 Oct 2018 09:19:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log

Message #59 received at 33059 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: 33059 <at> debbugs.gnu.org
Subject: Re: [bug#33059] [PATCH 04/10] gnu: Add python-fenics-dijitso.
Date: Wed, 24 Oct 2018 23:48:07 +0200

Paul Garlick <pgarlick <at> tourbillion-technology.com> skribis:

> * gnu/packages/simulation.scm (python-fenics-dijitso): New varaible.

I agree with Efraim’s suggestion to use ‘with-directory-excursion’.

Nitpick:

> +      (home-page
> +      "https://bitbucket.org/fenics-project/dijitso/")

Indentation is off.

> +    (synopsis
> +      "Distributed just-in-time building of shared libraries")

Please keep ‘home-page’ and ‘synopsis’ on a single line each.

Otherwise LGTM, thanks!

Ludo’.
This bug report was last modified 6 years and 242 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.