GNU bug report logs - #33058
[PATCH] gnu: Add i3blocks.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33058 in the body.
You can then email your comments to 33058 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo.peng <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add i3blocks.
Date: Tue, 16 Oct 2018 16:43:11 +0800

Hello,

I created a package for i3blocks. This is my first guix package, so
forgive me if i did anything wrong.


From 6116bec4d60175e2d1fb12da75c803962ddb3ec7 Mon Sep 17 00:00:00 2001
From: Meiyo Peng <meiyo.peng <at> gmail.com>
Date: Tue, 16 Oct 2018 15:16:43 +0800
Subject: [PATCH] gnu: Add i3blocks.

* gnu/packages/wm.scm (i3blocks): New variable.
---
 gnu/packages/wm.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 7c58770de..d5e191770 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2017 Oleg Pykhalov <go.wigust <at> gmail.com>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <contact <at> parouby.fr>
+;;; Copyright © 2018 Meiyo Peng <meiyo.peng <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -233,6 +234,46 @@ from scratch.  i3 is primarily targeted at advanced users and
 developers.")
     (license license:bsd-3)))
 
+(define-public i3blocks
+  (let ((commit "37f23805ff886639163fbef8aedba71c8071eff8")
+        (revision "1"))
+    (package
+      (name "i3blocks")
+      (version (string-append "1.4-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/vivien/i3blocks.git")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "15rnrcajzyrmhlz1a21qqsjlj3dkib70806dlb386fliylc2kisb"))
+                (file-name (string-append name "-" version "-checkout"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
+         #:phases (modify-phases %standard-phases
+                    (add-after 'unpack 'autogen
+                      (lambda _ (invoke "sh" "autogen.sh")))
+                    (add-after 'install 'install-doc
+                      (lambda* (#:key outputs #:allow-other-keys)
+                        (let* ((out (assoc-ref outputs "out"))
+                               (man1 (string-append out "/share/man/man1")))
+                          (install-file "docs/i3blocks.1" man1)))))
+         #:tests? #f))
+      (native-inputs
+       `(("autoconf" ,autoconf)
+         ("automake" ,automake)
+         ("pkg-config" ,pkg-config)))
+      (home-page "https://github.com/vivien/i3blocks")
+      (synopsis "Minimalist scheduler for status bar scripts")
+      (description "i3blocks executes your command lines and generates a
+status line from their output.  The generated line is meant to be displayed by
+the i3 window manager through its i3bar component, as an alternative to
+i3status.")
+      (license license:gpl3+))))
+
 (define-public perl-anyevent-i3
   (package
     (name "perl-anyevent-i3")
-- 
2.19.1

Message #10 received at 33058-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Meiyo Peng <meiyo.peng <at> gmail.com>
Cc: 33058-done <at> debbugs.gnu.org
Subject: Re: [bug#33058] [PATCH] gnu: Add i3blocks.
Date: Fri, 19 Oct 2018 22:45:47 +0200

[Message part 1 (text/plain, inline)]

Hi Meiyo,

Meiyo Peng <meiyo.peng <at> gmail.com> skribis:

> I created a package for i3blocks. This is my first guix package, so
> forgive me if i did anything wrong.

It looks great to me!

>>From 6116bec4d60175e2d1fb12da75c803962ddb3ec7 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Tue, 16 Oct 2018 15:16:43 +0800
> Subject: [PATCH] gnu: Add i3blocks.
>
> * gnu/packages/wm.scm (i3blocks): New variable.

I’ve applied it with the minor changes below: leave the default value of
#:tests? (it doesn’t hurt), and return #t in the build phase.  That’s
#it!

Thank you for the patch, and welcome!  :-)

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index d5e191770..68d497e95 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -260,8 +260,8 @@ developers.")
                       (lambda* (#:key outputs #:allow-other-keys)
                         (let* ((out (assoc-ref outputs "out"))
                                (man1 (string-append out "/share/man/man1")))
-                          (install-file "docs/i3blocks.1" man1)))))
-         #:tests? #f))
+                          (install-file "docs/i3blocks.1" man1)
+                          #t))))))
       (native-inputs
        `(("autoconf" ,autoconf)
          ("automake" ,automake)

Message #13 received at 33058 <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo.peng <at> gmail.com>
To: ludo <at> gnu.org
Cc: 33058 <at> debbugs.gnu.org
Subject: Re: [bug#33058] [PATCH] gnu: Add i3blocks.
Date: Sat, 20 Oct 2018 10:27:56 +0800

Hi Ludo,

On Fri, Oct 19, 2018 at 8:45 PM Ludovic Courtès <ludo <at> gnu.org> wrote:

> I’ve applied it with the minor changes below: leave the default value of
> #:tests? (it doesn’t hurt), and return #t in the build phase.  That’s
> #it!

Thank you, Ludo. I will do better next time.

> Thank you for the patch, and welcome!  :-)

I love guix, and I'm migrating all my computers to guix! Thank you for
your contributions to the guix community!

--
Meiyo Peng

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.