GNU bug report logs - #33058
[PATCH] gnu: Add i3blocks.

Previous Next

Full log

Message #10 received at 33058-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Meiyo Peng <meiyo.peng <at> gmail.com>
Cc: 33058-done <at> debbugs.gnu.org
Subject: Re: [bug#33058] [PATCH] gnu: Add i3blocks.
Date: Fri, 19 Oct 2018 22:45:47 +0200

[Message part 1 (text/plain, inline)]

Hi Meiyo,

Meiyo Peng <meiyo.peng <at> gmail.com> skribis:

> I created a package for i3blocks. This is my first guix package, so
> forgive me if i did anything wrong.

It looks great to me!

>>From 6116bec4d60175e2d1fb12da75c803962ddb3ec7 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Tue, 16 Oct 2018 15:16:43 +0800
> Subject: [PATCH] gnu: Add i3blocks.
>
> * gnu/packages/wm.scm (i3blocks): New variable.

I’ve applied it with the minor changes below: leave the default value of
#:tests? (it doesn’t hurt), and return #t in the build phase.  That’s
#it!

Thank you for the patch, and welcome!  :-)

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index d5e191770..68d497e95 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -260,8 +260,8 @@ developers.")
                       (lambda* (#:key outputs #:allow-other-keys)
                         (let* ((out (assoc-ref outputs "out"))
                                (man1 (string-append out "/share/man/man1")))
-                          (install-file "docs/i3blocks.1" man1)))))
-         #:tests? #f))
+                          (install-file "docs/i3blocks.1" man1)
+                          #t))))))
       (native-inputs
        `(("autoconf" ,autoconf)
          ("automake" ,automake)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.