GNU bug report logs - #32994
27.0.50; Regression in image type auto-detection

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Subject: bug#32994: closed (Re: bug#32994: 27.0.50; Regression in image
 type auto-detection)
Date: Mon, 15 Oct 2018 22:35:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#32994: 27.0.50; Regression in image type auto-detection

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 32994 <at> debbugs.gnu.org.

-- 
32994: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32994
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: 32994-done <at> debbugs.gnu.org
Subject: Re: bug#32994: 27.0.50; Regression in image type auto-detection
Date: Tue, 16 Oct 2018 01:33:51 +0300

> Tags: patch
>
> A recent change in image-mode.el broke a useful feature that
> automatically detects an image type, so now visiting an image file
> without a file extension signals the error "upcase(nil) -
> (wrong-type-argument char-or-string-p nil)".  This patch fixes it:

Fixed.

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Regression in image type auto-detection
Date: Tue, 09 Oct 2018 01:08:13 +0300

Tags: patch

A recent change in image-mode.el broke a useful feature that
automatically detects an image type, so now visiting an image file
without a file extension signals the error "upcase(nil) -
(wrong-type-argument char-or-string-p nil)".  This patch fixes it:

diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 19fa28d440..eb7b410f4a 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -781,8 +785,9 @@ image-toggle-display-image
 (defun image--imagemagick-wanted-p (filename)
   (and (fboundp 'imagemagick-types)
        (not (eq imagemagick-types-inhibit t))
-       (not (memq (intern (upcase (file-name-extension filename)) obarray)
-                  imagemagick-types-inhibit))))
+       (not (and (file-name-extension filename)
+                 (memq (intern (upcase (file-name-extension filename)) obarray)
+                       imagemagick-types-inhibit)))))
 
 (defun image-toggle-hex-display ()
   "Toggle between image and hex display."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.