GNU bug report logs - #32994
27.0.50; Regression in image type auto-detection

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Mon, 8 Oct 2018 23:03:01 UTC

Severity: normal

Tags: patch

Found in version 27.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32994 in the body.
You can then email your comments to 32994 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#32994; Package emacs. (Mon, 08 Oct 2018 23:03:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Juri Linkov <juri <at> linkov.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 08 Oct 2018 23:03:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Regression in image type auto-detection
Date: Tue, 09 Oct 2018 01:08:13 +0300

Tags: patch

A recent change in image-mode.el broke a useful feature that
automatically detects an image type, so now visiting an image file
without a file extension signals the error "upcase(nil) -
(wrong-type-argument char-or-string-p nil)".  This patch fixes it:

diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 19fa28d440..eb7b410f4a 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -781,8 +785,9 @@ image-toggle-display-image
 (defun image--imagemagick-wanted-p (filename)
   (and (fboundp 'imagemagick-types)
        (not (eq imagemagick-types-inhibit t))
-       (not (memq (intern (upcase (file-name-extension filename)) obarray)
-                  imagemagick-types-inhibit))))
+       (not (and (file-name-extension filename)
+                 (memq (intern (upcase (file-name-extension filename)) obarray)
+                       imagemagick-types-inhibit)))))
 
 (defun image-toggle-hex-display ()
   "Toggle between image and hex display."
Reply sent to Juri Linkov <juri <at> linkov.net>:
You have taken responsibility. (Mon, 15 Oct 2018 22:35:02 GMT) Full text and rfc822 format available.
Notification sent to Juri Linkov <juri <at> linkov.net>:
bug acknowledged by developer. (Mon, 15 Oct 2018 22:35:02 GMT) Full text and rfc822 format available.

Message #10 received at 32994-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 32994-done <at> debbugs.gnu.org
Subject: Re: bug#32994: 27.0.50; Regression in image type auto-detection
Date: Tue, 16 Oct 2018 01:33:51 +0300

> Tags: patch
>
> A recent change in image-mode.el broke a useful feature that
> automatically detects an image type, so now visiting an image file
> without a file extension signals the error "upcase(nil) -
> (wrong-type-argument char-or-string-p nil)".  This patch fixes it:

Fixed.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 13 Nov 2018 12:24:14 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 218 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.