GNU bug report logs - #32975
Emacs 26.1; GTK Warnings

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Tjernlund <tjernlund <at> tjernlund.se>, 32975 <at> debbugs.gnu.org
Subject: bug#32975: Emacs 26.1; GTK Warnings
Date: Thu, 11 Oct 2018 14:02:25 +0200

> There is only one call to xg_set_background_color, from xfns.c, which looks
> like this with my patch applied:
>
> #ifdef USE_TOOLKIT_SCROLL_BARS
> # ifdef USE_GTK
>        xg_set_background_color (f, bg);
> # endif
> #else
>
> So it will only ever happen when the scrollbars are GTK widgets.

But this effectively throws out the baby - painting the background of
the frame widget proper via

      xg_set_widget_bg (f, FRAME_GTK_WIDGET (f), FRAME_BACKGROUND_PIXEL (f));

with the bathwater - painting the background of non-existent scroll
bar widgets via

          xg_set_widget_bg (f, webox, FRAME_BACKGROUND_PIXEL (f));

for GTK builds with native Emacs scroll bars.  Maybe on X the

      XSetWindowBackground (dpy, FRAME_X_WINDOW (f), bg);

in x_set_background_color would take care of that.  But are we sure?

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.