GNU bug report logs - #32976
[PATCH] Add gimp-resynthesizer package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32976 in the body.
You can then email your comments to 32976 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Wilms <t_w_ <at> freenet.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add gimp-resynthesizer package
Date: Sun, 7 Oct 2018 20:31:57 +0200

* gnu/packages/gimp.scm (gimp-resynthesizer): New variable.
---
 gnu/packages/gimp.scm | 61 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index df8f242c7..2e74f3128 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2016, 2017, 2018 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2018 Thorsten Wilms <t_w_ <at> freenet.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -305,3 +306,63 @@ brushstrokes which is used by MyPaint and GIMP.")
 MyPaint.")
     (home-page "https://github.com/Jehan/mypaint-brushes")
     (license license:cc0)))
+
+(define-public gimp-resynthesizer
+  ;; GIMP does not respect any plugin search path environment variable, 
so after
+  ;; installation users have to edit their GIMP settings to include
+  ;; "$HOME/.guix-profile/lib/gimp/2.0/plug-ins/" in
+  ;; “Edit->Preferences->Folders->Plug Ins”.
+  (package
+   (name "gimp-resynthesizer")
+   (version "2.0.3")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (string-append 
"https://github.com/bootchk/resynthesizer/archive/v"
+			 version
+			 ".tar.gz"))
+     (sha256 (base32 
"0l3404w6rqny7h3djskxf149gzx6x4qhndgbh3403c9lbh4pi1kr"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(;; Turn off tests to avoid:
+      ;; make[1]: *** No rule to make target '../src/resynth-gui.c', 
needed by 'resynthesizer.pot'.  Stop.
+      #:tests? #f
+      #:phases
+      (modify-phases %standard-phases
+	(add-after 'unpack 'set-env
+	  (lambda _
+	    (setenv "CONFIG_SHELL" (which "sh"))
+	    #t))
+	(add-after 'configure 'set-prefix
+	  ;; Attempt to install to GIMP's plugin directory will fail.
+	  ;; Use own store address.
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let ((target (string-append (assoc-ref outputs "out")
+                                         "/lib/gimp/"
+                                         (car (string-split 
,(package-version gimp) #\.))
+                                         ".0")))
+              (substitute* (list "src/resynthesizer/Makefile"
+				 "src/resynthesizer-gui/Makefile")
+		(("GIMP_LIBDIR = .*")
+                 (string-append "GIMP_LIBDIR = " target "\n")))
+              (mkdir-p target))
+            #t))
+	)))
+   (native-inputs
+    `(("autoconf" ,autoconf-wrapper)
+      ("automake" ,automake)
+      ("glib" ,glib "bin") ; glib-gettextize
+      ("intltool" ,intltool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("gimp" ,gimp)
+      ("gdk-pixbuf" ,gdk-pixbuf) ; needed by gimp-2.0.pc
+      ("cairo" ,cairo)
+      ("gegl" ,gegl)
+      ("gtk+" ,gtk+-2) ; needed by gimpui-2.0.pc
+      ("glib" ,glib)))
+   (home-page "https://github.com/bootchk/resynthesizer")
+   (synopsis "GIMP plugins for texture synthesis")
+   (description
+    "Resynthesizer plugins for GIMP. Encompasses tools for healing 
selections (content aware fill), enlarging the canvas and healing the 
border, increasing the resolution while adding detail and transfering 
the style of an image.")
+   (license license:gpl3+)))
-- 
2.19.0


-- 
Thorsten Wilms

thorwil's design for free software:
http://thorwil.wordpress.com/

Message #8 received at 32976 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Thorsten Wilms <t_w_ <at> freenet.de>
Cc: 32976 <at> debbugs.gnu.org
Subject: Re: [bug#32976] [PATCH] Add gimp-resynthesizer package
Date: Mon, 08 Oct 2018 18:23:01 +0200

Thorsten Wilms <t_w_ <at> freenet.de> skribis:

> * gnu/packages/gimp.scm (gimp-resynthesizer): New variable.

[...]

> +     (uri (string-append
> "https://github.com/bootchk/resynthesizer/archive/v"
> +			 version

This patch was also garbled by the email client’s line-wrapping, I
suppose.

Could you try to resend it?

Thanks,
Ludo’.

Message #11 received at 32976 <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Wilms <t_w_ <at> freenet.de>
To: 32976 <at> debbugs.gnu.org
Cc: Thorsten Wilms <t_w_ <at> freenet.de>
Subject: [PATCH] * gnu/packages/gimp.scm (gimp-resynthesizer): New variable.
Date: Mon,  8 Oct 2018 21:11:10 +0200

---
 gnu/packages/gimp.scm | 61 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index df8f242c7..2e74f3128 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2016, 2017, 2018 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2018 Thorsten Wilms <t_w_ <at> freenet.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -305,3 +306,63 @@ brushstrokes which is used by MyPaint and GIMP.")
 MyPaint.")
     (home-page "https://github.com/Jehan/mypaint-brushes")
     (license license:cc0)))
+
+(define-public gimp-resynthesizer
+  ;; GIMP does not respect any plugin search path environment variable, so after
+  ;; installation users have to edit their GIMP settings to include
+  ;; "$HOME/.guix-profile/lib/gimp/2.0/plug-ins/" in
+  ;; “Edit->Preferences->Folders->Plug Ins”.
+  (package
+   (name "gimp-resynthesizer")
+   (version "2.0.3")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (string-append "https://github.com/bootchk/resynthesizer/archive/v"
+			 version
+			 ".tar.gz"))
+     (sha256 (base32 "0l3404w6rqny7h3djskxf149gzx6x4qhndgbh3403c9lbh4pi1kr"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(;; Turn off tests to avoid:
+      ;; make[1]: *** No rule to make target '../src/resynth-gui.c', needed by 'resynthesizer.pot'.  Stop.
+      #:tests? #f
+      #:phases
+      (modify-phases %standard-phases
+	(add-after 'unpack 'set-env
+	  (lambda _
+	    (setenv "CONFIG_SHELL" (which "sh"))
+	    #t))
+	(add-after 'configure 'set-prefix
+	  ;; Attempt to install to GIMP's plugin directory will fail.
+	  ;; Use own store address.
+          (lambda* (#:key outputs #:allow-other-keys)            
+            (let ((target (string-append (assoc-ref outputs "out")
+                                         "/lib/gimp/"
+                                         (car (string-split ,(package-version gimp) #\.))
+                                         ".0")))
+              (substitute* (list "src/resynthesizer/Makefile"
+				 "src/resynthesizer-gui/Makefile")
+		(("GIMP_LIBDIR = .*")
+                 (string-append "GIMP_LIBDIR = " target "\n")))
+              (mkdir-p target))
+            #t))
+	)))
+   (native-inputs
+    `(("autoconf" ,autoconf-wrapper)
+      ("automake" ,automake)      
+      ("glib" ,glib "bin") ; glib-gettextize
+      ("intltool" ,intltool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("gimp" ,gimp)      
+      ("gdk-pixbuf" ,gdk-pixbuf) ; needed by gimp-2.0.pc
+      ("cairo" ,cairo)
+      ("gegl" ,gegl)
+      ("gtk+" ,gtk+-2) ; needed by gimpui-2.0.pc
+      ("glib" ,glib)))
+   (home-page "https://github.com/bootchk/resynthesizer")
+   (synopsis "GIMP plugins for texture synthesis")
+   (description
+    "Resynthesizer plugins for GIMP. Encompasses tools for healing selections (content aware fill), enlarging the canvas and healing the border, increasing the resolution while adding detail and transfering the style of an image.")
+   (license license:gpl3+)))
-- 
2.19.0

Message #16 received at 32976-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Thorsten Wilms <t_w_ <at> freenet.de>
Cc: 32976-done <at> debbugs.gnu.org
Subject: Re: [bug#32976] [PATCH] * gnu/packages/gimp.scm (gimp-resynthesizer):
 New variable.
Date: Mon, 08 Oct 2018 23:22:05 +0200

[Message part 1 (text/plain, inline)]

Thorsten Wilms <t_w_ <at> freenet.de> skribis:

> ---
>  gnu/packages/gimp.scm | 61 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)

Applied with the changes below.

Thanks!

Ludo'.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index 2e74f3128..cd0deac15 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -319,9 +319,11 @@ MyPaint.")
      (origin
        (method url-fetch)
        (uri (string-append "https://github.com/bootchk/resynthesizer/archive/v"
-			 version
-			 ".tar.gz"))
-     (sha256 (base32 "0l3404w6rqny7h3djskxf149gzx6x4qhndgbh3403c9lbh4pi1kr"))))
+			   version ".tar.gz"))
+       (sha256
+        (base32
+         "0l3404w6rqny7h3djskxf149gzx6x4qhndgbh3403c9lbh4pi1kr"))
+       (file-name (string-append name "-" version ".tar.gz"))))
     (build-system gnu-build-system)
     (arguments
      `( ;; Turn off tests to avoid:
@@ -334,20 +336,19 @@ MyPaint.")
 	     (setenv "CONFIG_SHELL" (which "sh"))
 	     #t))
 	 (add-after 'configure 'set-prefix
-	  ;; Attempt to install to GIMP's plugin directory will fail.
-	  ;; Use own store address.
+           ;; Install plugin under $prefix, not under GIMP's libdir.
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((target (string-append (assoc-ref outputs "out")
                                           "/lib/gimp/"
-                                         (car (string-split ,(package-version gimp) #\.))
+                                          ,(version-major
+                                            (package-version gimp))
                                           ".0")))
                (substitute* (list "src/resynthesizer/Makefile"
 				  "src/resynthesizer-gui/Makefile")
 		 (("GIMP_LIBDIR = .*")
                   (string-append "GIMP_LIBDIR = " target "\n")))
-              (mkdir-p target))
-            #t))
-	)))
+               (mkdir-p target)
+               #t))))))
     (native-inputs
      `(("autoconf" ,autoconf-wrapper)
        ("automake" ,automake)
@@ -364,5 +365,8 @@ MyPaint.")
     (home-page "https://github.com/bootchk/resynthesizer")
     (synopsis "GIMP plugins for texture synthesis")
     (description
-    "Resynthesizer plugins for GIMP. Encompasses tools for healing selections (content aware fill), enlarging the canvas and healing the border, increasing the resolution while adding detail and transfering the style of an image.")
+     "This package provides resynthesizer plugins for GIMP, which encompasses
+tools for healing selections (content-aware fill), enlarging the canvas and
+healing the border, increasing the resolution while adding detail, and
+transfering the style of an image.")
     (license license:gpl3+)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.