GNU bug report logs - #32975
Emacs 26.1; GTK Warnings

Previous Next

Package: emacs;

Reported by: Tjernlund <tjernlund <at> tjernlund.se>

Date: Sun, 7 Oct 2018 18:33:02 UTC

Severity: normal

Tags: fixed

Fixed in version 26.2

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #62 received at 32975 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Tjernlund <tjernlund <at> tjernlund.se>, 32975 <at> debbugs.gnu.org
Subject: Re: bug#32975: Emacs 26.1; GTK Warnings
Date: Thu, 11 Oct 2018 11:50:04 +0200

martin rudalics <rudalics <at> gmx.at> writes:

>> We do, but I only see xg_set_widget_bg getting called on scrollbar
>> widgets when USE_TOOLKIT_SCROLL_BARS is set, in which case they're GTK
>> widgets, so thatʼs the right thing to do.
>
> I apologize for my stubbornness.
>

No apology needed

> xg_set_background_color (struct frame *f, unsigned long bg)
>
> has
>
>       xg_set_widget_bg (f, FRAME_GTK_WIDGET (f), FRAME_BACKGROUND_PIXEL (f));
>
> which IIUC does not work on scrollbar widgets.

There is only one call to xg_set_background_color, from xfns.c, which looks
like this with my patch applied:

#ifdef USE_TOOLKIT_SCROLL_BARS
# ifdef USE_GTK
      xg_set_background_color (f, bg);
# endif
#else

So it will only ever happen when the scrollbars are GTK widgets.

Robert
This bug report was last modified 6 years and 224 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.