GNU bug report logs - #32760
[PATCH] gnu: git-credential-netrc: Add Git.pm to PERL5LIB.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <mail <at> ambrevar.xyz>

Date: Tue, 18 Sep 2018 15:17:02 UTC

Severity: normal

Tags: patch

Merged with 32761

Done: Pierre Neidhardt <mail <at> ambrevar.xyz>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32760 in the body.
You can then email your comments to 32760 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#32760; Package guix-patches. (Tue, 18 Sep 2018 15:17:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 18 Sep 2018 15:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: git-credential-netrc: Add Git.pm to PERL5LIB.
Date: Tue, 18 Sep 2018 12:29:24 +0200

* gnu/packages/version-control.scm (git)[credential-netrc]: Add Git.pm to PERL5LIB.
---
 gnu/packages/version-control.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 377496178..58c870df5 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -309,6 +309,13 @@ as well as the classic centralized workflow.")
             (let* ((netrc (assoc-ref outputs "credential-netrc")))
               (install-file "contrib/credential/netrc/git-credential-netrc"
                             (string-append netrc "/bin"))
+              ;; Previously, Git.pm was automatically found by netrc.
+              ;; Perl 5.26 changed how it locates modules so that @INC no
+              ;; longer includes the current working directory (the Perl
+              ;; community calls this "dotless @INC").
+              (wrap-program (string-append netrc "/bin/git-credential-netrc")
+                `("PERL5LIB" ":" prefix
+                  (,(string-append (assoc-ref outputs "out") "/share/perl5"))))
               #t)))
         (add-after 'install 'split
           (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.19.0
Merged 32760 32761. Request was from Leo Famulari <leo <at> famulari.name> to control <at> debbugs.gnu.org. (Tue, 18 Sep 2018 18:17:02 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#32760; Package guix-patches. (Tue, 18 Sep 2018 19:02:02 GMT) Full text and rfc822 format available.

Message #10 received at 32760 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 32760 <at> debbugs.gnu.org
Subject: Re: [bug#32760] [PATCH] gnu: git-credential-netrc: Add Git.pm to
 PERL5LIB.
Date: Tue, 18 Sep 2018 15:00:58 -0400

[Message part 1 (text/plain, inline)]
On Tue, Sep 18, 2018 at 12:29:24PM +0200, Pierre Neidhardt wrote:
> * gnu/packages/version-control.scm (git)[credential-netrc]: Add Git.pm to PERL5LIB.

Thanks, LGTM!

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#32760; Package guix-patches. (Tue, 18 Sep 2018 19:03:02 GMT) Full text and rfc822 format available.

Message #13 received at 32760 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32760 <at> debbugs.gnu.org
Subject: Re: [bug#32760] [PATCH] gnu: git-credential-netrc: Add Git.pm to
 PERL5LIB.
Date: Tue, 18 Sep 2018 21:02:15 +0200

[Message part 1 (text/plain, inline)]
I'll merge in a little while then.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]
Reply sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
You have taken responsibility. (Wed, 19 Sep 2018 07:10:01 GMT) Full text and rfc822 format available.
Notification sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
bug acknowledged by developer. (Wed, 19 Sep 2018 07:10:02 GMT) Full text and rfc822 format available.

Message #18 received at 32760-done <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 32760-done <at> debbugs.gnu.org
Subject: [bug#32760] [PATCH] gnu: git-credential-netrc: Add Git.pm to PERL5LIB.
Date: Wed, 19 Sep 2018 09:09:03 +0200

[Message part 1 (text/plain, inline)]
close

[signature.asc (application/pgp-signature, inline)]
Reply sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
You have taken responsibility. (Wed, 19 Sep 2018 07:10:02 GMT) Full text and rfc822 format available.
Notification sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
bug acknowledged by developer. (Wed, 19 Sep 2018 07:10:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 17 Oct 2018 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 249 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.