GNU bug report logs - #32755
[PATCH] erc.el: Remove warning during compilation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32755 in the body.
You can then email your comments to 32755 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Beauchamp <beauchampgabriel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] erc.el: Remove warning during compilation.
Date: Mon, 17 Sep 2018 17:37:20 -0400

[Message part 1 (text/plain, inline)]

Hi,

I have attached a patch that removes a warning during the compilation of
erc. Tested with `emacs -Q -q' running on HEAD.

Thanks,
Gabriel

[0001-lisp-erc-erc.el-erc-handle-irc-url-Remove-warning-du.patch (text/x-diff, inline)]

From cc6d9c0c83fb62172aec5456c1ae16f217478346 Mon Sep 17 00:00:00 2001
From: Gabriel Beauchamp <beauchampgabriel <at> gmail.com>
Date: Mon, 17 Sep 2018 17:07:13 -0400
Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove warning during
 compilation.

---
 lisp/erc/erc.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index fc51009641..eb9082fa2f 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -5450,14 +5450,14 @@ erc-send-input
       (beep))
     nil)
    (t
-    (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention.
-    (let ((str input)
+    (defvar erc--str)
+    (let ((erc--str input)
           (erc-insert-this t))
       (setq erc-send-this t)
       (run-hook-with-args 'erc-send-pre-hook input)
       (when erc-send-this
-        (if (or (string-match "\n" str)
-                (not (string-match erc-command-regexp str)))
+        (if (or (string-match "\n" erc--str)
+                (not (string-match erc-command-regexp erc--str)))
             (mapc
              (lambda (line)
                (mapc
@@ -5468,8 +5468,8 @@ erc-send-input
                                           (null erc-flood-protect) t))
                 (or (and erc-flood-protect (erc-split-line line))
                     (list line))))
-             (split-string str "\n"))
-          (erc-process-input-line (concat str "\n") t nil))
+             (split-string erc--str "\n"))
+          (erc-process-input-line (concat erc--str "\n") t nil))
         t)))))
 
 (defun erc-display-command (line)
-- 
2.17.1

Message #8 received at 32755 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Gabriel Beauchamp <beauchampgabriel <at> gmail.com>
Cc: 32755 <at> debbugs.gnu.org
Subject: Re: bug#32755: [PATCH] erc.el: Remove warning during compilation.
Date: Mon, 17 Sep 2018 23:19:28 -0400

Gabriel Beauchamp wrote:

> I have attached a patch that removes a warning during the compilation of
> erc. Tested with `emacs -Q -q' running on HEAD.

Thanks for the patch, however if someone writes FIXME for this kind of
thing rather than just doing it, it's usually because it's not so
straightforward. In this case, `str' is an advertised part of the
interface - see doc of `erc-send-pre-hook'.

> Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove
> warning during compilation.

You changed erc-send-input, not erc-handle-irc-url.
(You can use eg C-x 4 a on the diff for this kind of thing.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.