GNU bug report logs - #32592
s with i modifier seems to work incorrectly

Previous Next

Full log

Message #29 received at 32592 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: bill-auger <at> peers.community, Eric Blake <eblake <at> redhat.com>,
 32592 <at> debbugs.gnu.org, tails.saito <at> gmail.com,
 "bug-gnulib <at> gnu.org List" <bug-gnulib <at> gnu.org>
Subject: Re: bug#32592: heap-use-after-free in regex module
Date: Wed, 5 Sep 2018 19:28:14 -0600

[Message part 1 (text/plain, inline)]

Bruno alerted me off-list:

On 05/09/18 07:19 PM, Bruno Haible wrote:
> Is the ChangeLog entry up-to-date?
>
> +	* regexec.c (get_subexp): Update 'buf' after call to get_subexp_sub.
> +	Additionally, check for allocation errors and bail out if needed.
>
> I don't see a code change for
> "check for allocation errors and bail out if needed".

Thanks!

I initially had a check for REG_NOERROR there, but removed it.

Attached an updated patch without the outdated comment.

-assaf

[0001-regex-fix-heap-use-after-free-error.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.