GNU bug report logs - #32537
26.1.50; Tramp: Cursor jumps when typing during asynchronous find-file

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Gemini Lasswell <gazally <at> runbox.com>, 32537 <at> debbugs.gnu.org
Subject: bug#32537: 26.1.50; Tramp: Cursor jumps when typing during asynchronous find-file
Date: Sun, 02 Sep 2018 10:33:51 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> tramp-sh-handle-file-attributes enters its save-excursion form which
>> saves a marker pointing to 256 in *scratch* in the special binding stack
>> of Thread 10.
>
> Why does it call save-excursion if it is going to switch to another
> buffer?  The call to save-excursion is only needed if the program is
> about to move point in the current buffer.

Don't know. Several save-excursion calls are there for decades. They
didn't hurt until now (maybe some slight performance penalties).

I've removed some of them, where it looks appropriate. Pushed to the
feature/tramp-thread-safe branch. tramp-tests still pass successfully,
and the error as described in this bug didn't happen any more for me.

I've checked also the other tramp*.el files, but there isn't any
suspicious save-excursion use.

Gemini, could you pls crosscheck that it is fixed?

Thanks, and best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.