GNU bug report logs - #32538
[PATCH] Add emacs-elpy

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32538 in the body.
You can then email your comments to 32538 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] Add emacs-elpy
Date: Mon, 27 Aug 2018 01:00:37 -0400

[Message part 1 (text/plain, inline)]

Hello,

This adds emacs-elpy to our collection, a worthy addition to Emacs when
in need of editing some Python.

To get the full experience, you'll want to install the following
(optional) additions, like:

--8<---------------cut here---------------start------------->8---
guix package -i python-jedi python-autopep8 python-yapf python-black python-flake8
--8<---------------cut here---------------end--------------->8---

You can enable Elpy by doing M-x elpy-mode in a Python buffer, and see
which tools are installed using M-x elpy-config.

Enjoy :)

Maxim

[0001-gnu-python-jedi-Update-to-0.12.1.patch (text/x-patch, attachment)]

[0002-gnu-Add-python-toml.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-black.patch (text/x-patch, attachment)]

[0004-gnu-Add-emacs-el-x.patch (text/x-patch, attachment)]

[0005-gnu-Add-emacs-mocker.patch (text/x-patch, attachment)]

[0006-gnu-Add-emacs-find-file-in-project.patch (text/x-patch, attachment)]

[0007-gnu-Add-emacs-pyvenv.patch (text/x-patch, attachment)]

[0008-gnu-Add-emacs-highlight-indentation.patch (text/x-patch, attachment)]

[0009-gnu-Add-emacs-elpy.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32538 <at> debbugs.gnu.org
Subject: Re: [bug#32538] [PATCHv2] Add emacs-elpy
Date: Tue, 28 Aug 2018 09:06:12 -0400

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello,
>
> This adds emacs-elpy to our collection, a worthy addition to Emacs when
> in need of editing some Python.
>
> To get the full experience, you'll want to install the following
> (optional) additions, like:
>
> guix package -i python-jedi python-autopep8 python-yapf python-black python-flake8
>
> You can enable Elpy by doing M-x elpy-mode in a Python buffer, and see
> which tools are installed using M-x elpy-config.
>
> Enjoy :)
>
> Maxim

This is a followup for the emacs-elpy package, where I added the info
and manpage documentation and fixed a couple small issues.

Thank you,

Maxim

[0009-gnu-Add-emacs-elpy.patch (text/x-patch, attachment)]

Message #11 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32538 <at> debbugs.gnu.org
Subject: Re: [bug#32538] [PATCH] Add emacs-elpy
Date: Mon, 03 Sep 2018 23:07:03 +0200

Hello Maxim,

I didn’t actually try the patch set but on a quick look it LGTM!
(Including v2 of the emacs-elpy patch itself.)

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 54130c8f5bcf683b1681e1a6c6238421bd0c6459 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Sun, 26 Aug 2018 23:56:15 -0400
> Subject: [PATCH 2/9] gnu: Add python-toml.
>
> * gnu/packages/python.scm (python-toml, python2-toml): New variables.

[...]

> +    (home-page "https://github.com/uiri/toml")
> +    (synopsis "Library for TOML")
> +    (description
> +     "@code{toml} is a library for Tom's Obvious, Minimal Language (TOML).")
> +    (license license:expat)))

Maybe “parser” instead of “library”?

> +(define-public python2-toml
> +  (package-with-python2 python-toml))

There was a loose consensus that if the Python 2 variant isn’t strictly
needed, then it’s best not to include it; so I think you can remove it.

> From 46ccd0d7093f9adbe091ec6e7846719e5ad267bf Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Mon, 12 Feb 2018 22:08:03 -0500
> Subject: [PATCH 4/9] gnu: Add emacs-el-x.
>
> * gnu/packages/emacs.scm (emacs-el-x): New variable.

[...]

> +    (home-page "https://github.com/sigma/el-x")
> +    (synopsis "Emacs Lisp extensions")
> +    (description "Defines the @code{dflet} macro to provide the historic
> +behavior of @code{flet}, as well as @code{declare-function} stub for older
> +Emacs.")

Full sentence please.  :-)

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'set-shell
> +           ;; Otherwise Emacs shell-file-name is set to "/bin/sh", which doesn't
> +           ;; work.
> +           (lambda _
> +             (setenv "SHELL" (which "sh")))))

This still needs to return #t, though I think Mark’s plan is to put an
end to that in the next ‘core-updates’ cycle.

> +    (home-page "https://github.com/antonj/Highlight-Indentation-for-Emacs/")
> +    (synopsis "Highlighting indentation for Emacs")
> +    (description "Provides two minor modes to highlight indentation guides in Emacs:
> +@enumerate
> +@item @code{highlight-indentation-mode}, which displays guidelines
> +indentation (space indentation only).
> +@item @code{ighlight-indentation-current-column-mode}, which displays guidelines for the current-point indentation (space indentation only).
              ^
Typo.

> +    (arguments
> +     `(#:include (cons* "^elpy\\/" "^snippets\\/" %default-include)
> +       #:phases
> +       ;; TODO: Make `elpy-config' display Guix commands :)
> +       (modify-phases %standard-phases
> +         ;; One elpy test depends on being run inside a Python virtual
> +         ;; environment to pass. We have nothing to gain from doing so here,
> +         ;; so we just trick Elpy into thinking we are (see:
> +         ;; https://github.com/jorgenschaefer/elpy/pull/1293).
> +         (add-before 'check 'fake-virtualenv
> +           (lambda _
> +             (setenv "VIRTUAL_ENV" "/tmp")))
> +         ;; TODO: Remove after next release (see:
> +         ;; https://github.com/jorgenschaefer/elpy/pull/1293).
> +         (add-after 'unpack 'fix-broken-test
> +           (lambda _
> +             (substitute* "test/elpy-config-test.el"
> +               (("python-check-command") "elpy-syntax-check-command")))))

Likewise for phase return values.

> +    (home-page "https://github.com/jorgenschaefer/elpy")
> +    (synopsis "Python development environment for Emacs")
> +    (description "Elpy brings powerful Python editing to Emacs.  It combines
> +and configures a number of other packages written in Emacs Lisp as well
> +as Python.")

If you could expound a little bit on the features (completion?
navigation? refactoring?), that would be great.

Otherwise LGTM, thanks!

Ludo’.

Message #14 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32538 <at> debbugs.gnu.org
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Wed, 05 Sep 2018 08:00:13 -0400

[Message part 1 (text/plain, inline)]

Hello Ludovic!

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello Maxim,
>
> I didn’t actually try the patch set but on a quick look it LGTM!
> (Including v2 of the emacs-elpy patch itself.)
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> From 54130c8f5bcf683b1681e1a6c6238421bd0c6459 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Sun, 26 Aug 2018 23:56:15 -0400
>> Subject: [PATCH 2/9] gnu: Add python-toml.
>>
>> * gnu/packages/python.scm (python-toml, python2-toml): New variables.
>
> [...]
>
>> +    (home-page "https://github.com/uiri/toml")
>> +    (synopsis "Library for TOML")
>> +    (description
>> +     "@code{toml} is a library for Tom's Obvious, Minimal Language (TOML).")
>> +    (license license:expat)))
>
> Maybe “parser” instead of “library”?

I've settled for this, taking inspiration from their project's page:

-     "@code{toml} is a library for Tom's Obvious, Minimal Language (TOML).")
+     "@code{toml} is a library for parsing and creating Tom's Obvious, Minimal
+Language (TOML) configuration files.")

>> +(define-public python2-toml
>> +  (package-with-python2 python-toml))
>
> There was a loose consensus that if the Python 2 variant isn’t strictly
> needed, then it’s best not to include it; so I think you can remove it.

Removed.

>> From 46ccd0d7093f9adbe091ec6e7846719e5ad267bf Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Mon, 12 Feb 2018 22:08:03 -0500
>> Subject: [PATCH 4/9] gnu: Add emacs-el-x.
>>
>> * gnu/packages/emacs.scm (emacs-el-x): New variable.
>
> [...]
>
>> +    (home-page "https://github.com/sigma/el-x")
>> +    (synopsis "Emacs Lisp extensions")
>> +    (description "Defines the @code{dflet} macro to provide the historic
>> +behavior of @code{flet}, as well as @code{declare-function} stub for older
>> +Emacs.")
>
> Full sentence please.  :-)

It now reads as:

-    (description "Defines the @code{dflet} macro to provide the historic
-behavior of @code{flet}, as well as @code{declare-function} stub for older
-Emacs.")
+    (description "command@{emacs-el-x} defines the @code{dflet} macro to
+provide the historic behavior of @code{flet}, as well as
+@code{declare-function} stub for older Emacs.")

>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'check 'set-shell
>> +           ;; Otherwise Emacs shell-file-name is set to "/bin/sh", which doesn't
>> +           ;; work.
>> +           (lambda _
>> +             (setenv "SHELL" (which "sh")))))
>
> This still needs to return #t, though I think Mark’s plan is to put an
> end to that in the next ‘core-updates’ cycle.

Done.

>
>> +    (home-page "https://github.com/antonj/Highlight-Indentation-for-Emacs/")
>> +    (synopsis "Highlighting indentation for Emacs")
>> +    (description "Provides two minor modes to highlight indentation guides in Emacs:
>> +@enumerate
>> +@item @code{highlight-indentation-mode}, which displays guidelines
>> +indentation (space indentation only).
>> +@item @code{ighlight-indentation-current-column-mode}, which displays guidelines for the current-point indentation (space indentation only).
>               ^
> Typo.

Fixed.

>> +    (arguments
>> +     `(#:include (cons* "^elpy\\/" "^snippets\\/" %default-include)
>> +       #:phases
>> +       ;; TODO: Make `elpy-config' display Guix commands :)
>> +       (modify-phases %standard-phases
>> +         ;; One elpy test depends on being run inside a Python virtual
>> +         ;; environment to pass. We have nothing to gain from doing so here,
>> +         ;; so we just trick Elpy into thinking we are (see:
>> +         ;; https://github.com/jorgenschaefer/elpy/pull/1293).
>> +         (add-before 'check 'fake-virtualenv
>> +           (lambda _
>> +             (setenv "VIRTUAL_ENV" "/tmp")))
>> +         ;; TODO: Remove after next release (see:
>> +         ;; https://github.com/jorgenschaefer/elpy/pull/1293).
>> +         (add-after 'unpack 'fix-broken-test
>> +           (lambda _
>> +             (substitute* "test/elpy-config-test.el"
>> +               (("python-check-command") "elpy-syntax-check-command")))))
>
> Likewise for phase return values.

Fixed!

>
>> +    (home-page "https://github.com/jorgenschaefer/elpy")
>> +    (synopsis "Python development environment for Emacs")
>> +    (description "Elpy brings powerful Python editing to Emacs.  It combines
>> +and configures a number of other packages written in Emacs Lisp as well
>> +as Python.")
>
> If you could expound a little bit on the features (completion?
> navigation? refactoring?), that would be great.

It now reads as:

-and configures a number of other packages written in Emacs Lisp as well
-as Python.")
+and configures a number of other packages written in Emacs Lisp as well as
+Python, together offering features such as navigation, documentation,
+completion, interactive development and more.")

I'm resending the modified full series of patches as v3, for ease of
use.

Thank you for reviewing!

Maxim

[0001-gnu-python-parso-Update-to-0.3.1.patch (text/x-patch, attachment)]

[0002-gnu-python-jedi-Update-to-0.12.1.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-toml.patch (text/x-patch, attachment)]

[0004-gnu-Add-python-black.patch (text/x-patch, attachment)]

[0005-gnu-Add-emacs-el-x.patch (text/x-patch, attachment)]

[0006-gnu-Add-emacs-mocker.patch (text/x-patch, attachment)]

[0007-gnu-Add-emacs-find-file-in-project.patch (text/x-patch, attachment)]

[0008-gnu-Add-emacs-pyvenv.patch (text/x-patch, attachment)]

[0009-gnu-Add-emacs-highlight-indentation.patch (text/x-patch, attachment)]

[0010-gnu-Add-emacs-elpy.patch (text/x-patch, attachment)]

Message #17 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32538 <at> debbugs.gnu.org
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Wed, 05 Sep 2018 14:13:05 +0200

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> I'm resending the modified full series of patches as v3, for ease of
> use.

Great, I think you can go ahead and push.

Thanks,
Ludo’.

Message #20 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org
Cc: 32538 <at> debbugs.gnu.org
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Wed, 05 Sep 2018 12:24:20 +0000

On September 5, 2018 12:13:05 PM UTC, ludo <at> gnu.org wrote:
>Hi Maxim,
>
>Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> I'm resending the modified full series of patches as v3, for ease of
>> use.
>
>Great, I think you can go ahead and push.
>
>Thanks,
>Ludo’.

Hi Ludovic,

I don't have push access at the moment; how should we proceed?

Maxim

Message #23 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 32538 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Thu, 06 Sep 2018 11:05:11 +0200

[Message part 1 (text/plain, inline)]

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> I don't have push access at the moment; how should we proceed?

Sorry, I thought you had push access.

Well, let’s fix this: can you create an account on Savannah, upload the
OpenPGP key you will be using to sign commits, and let me know the
account name?

Please send a reply signed with the key you’ll be using to sign commits.

Thanks in advance!

Ludo’.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 32538 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Thu, 6 Sep 2018 13:38:40 -0400

[Message part 1 (text/plain, inline)]

On Thu, Sep 06, 2018 at 11:05:11AM +0200, Ludovic Courtès wrote:
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
> 
> > I don't have push access at the moment; how should we proceed?
> 
> Well, let’s fix this: can you create an account on Savannah, upload the
> OpenPGP key you will be using to sign commits, and let me know the
> account name?

Welcome!

Please be sure to read 'HACKING' in the Guix source tree, and let us
know if you have any questions :)

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: Ricardo Wurmus <rekado <at> elephly.net>,
 Ludovic Courtès <ludo <at> gnu.org>, 32538 <at> debbugs.gnu.org
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Mon, 10 Sep 2018 23:08:43 -0400

[Message part 1 (text/plain, inline)]

Hello, and sorry for the delay.

Leo Famulari <leo <at> famulari.name> writes:

> On Thu, Sep 06, 2018 at 11:05:11AM +0200, Ludovic Courtès wrote:
>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>> 
>> > I don't have push access at the moment; how should we proceed?
>> 
>> Well, let’s fix this: can you create an account on Savannah, upload the
>> OpenPGP key you will be using to sign commits, and let me know the
>> account name?
>
> Welcome!
>
> Please be sure to read 'HACKING' in the Guix source tree, and let us
> know if you have any questions :)

I've done the necessary readings, thanks for pointing me to it.  I've
set the pre-push git hook to protect against pushing any unsigned
commit.

I've created my user account at Savannah; the username is 'apteryx'.

Thank you! :)

Maxim

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 32538 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Tue, 11 Sep 2018 09:09:52 +0200

[Message part 1 (text/plain, inline)]

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Thu, Sep 06, 2018 at 11:05:11AM +0200, Ludovic Courtès wrote:
>>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>>> 
>>> > I don't have push access at the moment; how should we proceed?
>>> 
>>> Well, let’s fix this: can you create an account on Savannah, upload the
>>> OpenPGP key you will be using to sign commits, and let me know the
>>> account name?
>>
>> Welcome!
>>
>> Please be sure to read 'HACKING' in the Guix source tree, and let us
>> know if you have any questions :)
>
> I've done the necessary readings, thanks for pointing me to it.  I've
> set the pre-push git hook to protect against pushing any unsigned
> commit.

Alright!

> I've created my user account at Savannah; the username is 'apteryx'.

Thanks, I’ve added you, so you can go ahead and push this patch series.

Welcome on board!  :-)

Ludo’.

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 32538 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 32538 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Tue, 11 Sep 2018 15:26:14 +0200

Hi Maxim,

> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Thu, Sep 06, 2018 at 11:05:11AM +0200, Ludovic Courtès wrote:
>>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>>> 
>>> > I don't have push access at the moment; how should we proceed?
>>> 
>>> Well, let’s fix this: can you create an account on Savannah, upload the
>>> OpenPGP key you will be using to sign commits, and let me know the
>>> account name?
>>
>> Welcome!
>>
>> Please be sure to read 'HACKING' in the Guix source tree, and let us
>> know if you have any questions :)
>
> I've done the necessary readings, thanks for pointing me to it.  I've
> set the pre-push git hook to protect against pushing any unsigned
> commit.
>
> I've created my user account at Savannah; the username is 'apteryx'.

Great!  Welcome, Maxim!

-- 
Ricardo

Message #40 received at 32538-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 32538-done <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [PATCHv3] Add emacs-elpy
Date: Wed, 12 Sep 2018 22:31:50 -0400

[Message part 1 (text/plain, inline)]

Hello,

ludo <at> gnu.org (Ludovic Courtès) writes:

[...]

>> I've created my user account at Savannah; the username is 'apteryx'.
>
> Thanks, I’ve added you, so you can go ahead and push this patch series.
>
> Welcome on board!  :-)

I've pushed this patch series to master as
82baeea2979b98a642dcfe63a87d08355a101f4c, after refreshing emacs-elpy to
its latest version (1.24) and testing it a bit to make sure everything
was still in order.

Thanks for the review and the warm welcome :)

Maxim

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.