GNU bug report logs - #32500
[PATCH 2/2] gnu: python-pkgconfig: Enable tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32500: closed ([PATCH 2/2] gnu: python-pkgconfig: Enable tests.)
Date: Wed, 22 Aug 2018 19:16:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 22 Aug 2018 15:15:00 -0400
with message-id <20180822191500.GB18201 <at> jasmine.lan>
and subject line Re: [bug#32497] [PATCH 0/2] *** python-pkgconfig ***
has caused the debbugs.gnu.org bug report #32500,
regarding [PATCH 2/2] gnu: python-pkgconfig: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32500: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32500
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Garlick <pgarlick <at> tourbillion-technology.com>
To: guix-patches <at> gnu.org
Cc: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: [PATCH 2/2] gnu: python-pkgconfig: Enable tests.
Date: Wed, 22 Aug 2018 17:41:27 +0100

* gnu/packages/python.scm (python-pkgconfig)[arguments]: Replace 'check'
phase.
---
 gnu/packages/python.scm | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index c0ad85c..3c46102 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8681,19 +8681,18 @@ CloudFront content delivery network.")
     (inputs
       `(("pkg-config" ,pkg-config)))
     (arguments
-      `(;; Tests fail with "ValueError: _type_ 'v' not supported" on Python 3,
-        ;; and on Python 2 they need the dl module deprecated since Python 2.6.
-        #:tests? #f
-        ;; Hard-code the path to pkg-config.
-        #:phases
+      `(#:phases
         (modify-phases %standard-phases
-          (add-before
-           'build 'patch
-           (lambda _
-             (substitute* "pkgconfig/pkgconfig.py"
-               (("cmd = 'pkg-config")
-                (string-append "cmd = '" (which "pkg-config"))))
-             #t)))))
+          (add-before 'build 'patch
+            ;; Hard-code the path to pkg-config.
+            (lambda _
+              (substitute* "pkgconfig/pkgconfig.py"
+                (("cmd = 'pkg-config")
+                 (string-append "cmd = '" (which "pkg-config"))))
+              #t))
+          (replace 'check
+            (lambda _
+              (invoke "nosetests" "test.py"))))))
     (home-page "https://github.com/matze/pkgconfig")
     (synopsis "Python interface for pkg-config")
     (description "This module provides a Python interface to pkg-config.  It
-- 
1.8.3.1

[Message part 3 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: 32497-done <at> debbugs.gnu.org, 32499-done <at> debbugs.gnu.org,
 32500-done <at> debbugs.gnu.org, 32498-done <at> debbugs.gnu.org
Subject: Re: [bug#32497] [PATCH 0/2] *** python-pkgconfig ***
Date: Wed, 22 Aug 2018 15:15:00 -0400

[Message part 4 (text/plain, inline)]

On Wed, Aug 22, 2018 at 05:33:52PM +0100, Paul Garlick wrote:
> *** The tests now pass with the updated version ***
> 
> Paul Garlick (2):
>   gnu: python-pkgconfig: Update to 1.3.1.
>   gnu: python-pkgconfig: Enable tests.

Thanks! Pushed as 414f620fbbba353986b2ecdb6274e35a53950323

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.