GNU bug report logs - #32500
[PATCH 2/2] gnu: python-pkgconfig: Enable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32500 in the body.
You can then email your comments to 32500 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Garlick <pgarlick <at> tourbillion-technology.com>
To: guix-patches <at> gnu.org
Cc: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: [PATCH 2/2] gnu: python-pkgconfig: Enable tests.
Date: Wed, 22 Aug 2018 17:41:27 +0100

* gnu/packages/python.scm (python-pkgconfig)[arguments]: Replace 'check'
phase.
---
 gnu/packages/python.scm | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index c0ad85c..3c46102 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8681,19 +8681,18 @@ CloudFront content delivery network.")
     (inputs
       `(("pkg-config" ,pkg-config)))
     (arguments
-      `(;; Tests fail with "ValueError: _type_ 'v' not supported" on Python 3,
-        ;; and on Python 2 they need the dl module deprecated since Python 2.6.
-        #:tests? #f
-        ;; Hard-code the path to pkg-config.
-        #:phases
+      `(#:phases
         (modify-phases %standard-phases
-          (add-before
-           'build 'patch
-           (lambda _
-             (substitute* "pkgconfig/pkgconfig.py"
-               (("cmd = 'pkg-config")
-                (string-append "cmd = '" (which "pkg-config"))))
-             #t)))))
+          (add-before 'build 'patch
+            ;; Hard-code the path to pkg-config.
+            (lambda _
+              (substitute* "pkgconfig/pkgconfig.py"
+                (("cmd = 'pkg-config")
+                 (string-append "cmd = '" (which "pkg-config"))))
+              #t))
+          (replace 'check
+            (lambda _
+              (invoke "nosetests" "test.py"))))))
     (home-page "https://github.com/matze/pkgconfig")
     (synopsis "Python interface for pkg-config")
     (description "This module provides a Python interface to pkg-config.  It
-- 
1.8.3.1

Message #10 received at 32500-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: 32497-done <at> debbugs.gnu.org, 32499-done <at> debbugs.gnu.org,
 32500-done <at> debbugs.gnu.org, 32498-done <at> debbugs.gnu.org
Subject: Re: [bug#32497] [PATCH 0/2] *** python-pkgconfig ***
Date: Wed, 22 Aug 2018 15:15:00 -0400

[Message part 1 (text/plain, inline)]

On Wed, Aug 22, 2018 at 05:33:52PM +0100, Paul Garlick wrote:
> *** The tests now pass with the updated version ***
> 
> Paul Garlick (2):
>   gnu: python-pkgconfig: Update to 1.3.1.
>   gnu: python-pkgconfig: Enable tests.

Thanks! Pushed as 414f620fbbba353986b2ecdb6274e35a53950323

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.