GNU bug report logs - #32474
27.0.50; Gnus doesn't highlight refined changes in diff attachments

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32474: closed (27.0.50; Gnus doesn't highlight refined
 changes in diff attachments)
Date: Thu, 30 Aug 2018 22:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 31 Aug 2018 01:17:14 +0300
with message-id <87tvnb33f9.fsf <at> mail.linkov.net>
and subject line Re: bug#32474: 27.0.50; Gnus doesn't highlight refined changes in diff attachments
has caused the debbugs.gnu.org bug report #32474,
regarding 27.0.50; Gnus doesn't highlight refined changes in diff attachments
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32474: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32474
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Gnus doesn't highlight refined changes in diff attachments
Date: Mon, 20 Aug 2018 00:20:02 +0300

[Message part 3 (text/plain, inline)]

Since refined changes in diff attachments are highlighted using overlays,
they need special treatment to be copied together with text properties:

[gnus-mm-view.1.patch (text/x-diff, inline)]

diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
index 50a927bce2..0b15f6b188 100644
--- a/lisp/gnus/mm-view.el
+++ b/lisp/gnus/mm-view.el
@@ -452,7 +452,7 @@ mm-display-inline-fontify
   "Insert HANDLE inline fontifying with MODE.
 If MODE is not set, try to find mode automatically."
   (let ((charset (mail-content-type-get (mm-handle-type handle) 'charset))
-	text coding-system)
+	text coding-system ovs)
     (unless (eq charset 'gnus-decoded)
       (mm-with-unibyte-buffer
 	(mm-insert-part handle)
@@ -498,10 +498,18 @@ mm-display-inline-fontify
 		      (eq major-mode 'fundamental-mode))
 	    (font-lock-ensure))))
       (setq text (buffer-string))
+      (when (eq mode 'diff-mode)
+	(setq ovs (mapcar (lambda (ov) (list ov (overlay-start ov)
+	                                        (overlay-end ov)))
+	                  (overlays-in (point-min) (point-max)))))
       ;; Set buffer unmodified to avoid confirmation when killing the
       ;; buffer.
       (set-buffer-modified-p nil))
-    (mm-insert-inline handle text)))
+    (let ((b (1- (point))))
+      (mm-insert-inline handle text)
+      (dolist (ov ovs)
+	(move-overlay (nth 0 ov) (+ (nth 1 ov) b)
+	                         (+ (nth 2 ov) b) (current-buffer))))))
 
 ;; Shouldn't these functions check whether the user even wants to use
 ;; font-lock?  Also, it would be nice to change for the size of the

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: 32474-done <at> debbugs.gnu.org
Subject: Re: bug#32474: 27.0.50;
 Gnus doesn't highlight refined changes in diff attachments
Date: Fri, 31 Aug 2018 01:17:14 +0300

> Since refined changes in diff attachments are highlighted using overlays,
> they need special treatment to be copied together with text properties:

Done in eb5588db69.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.