GNU bug report logs - #32475
27.0.50; Multiple log-view-mode buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32475 in the body.
You can then email your comments to 32475 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Multiple log-view-mode buffers
Date: Mon, 20 Aug 2018 00:31:50 +0300

[Message part 1 (text/plain, inline)]

To support the ability to create multiple *vc-change-log* buffers
with customization like

  (add-hook 'log-view-mode-hook 'rename-uniquely)

vc-log-internal-common needs an improvement to remember and reuse
the buffer object, instead of searching the same buffer by name:

[vc-log-internal-common.1.patch (text/x-diff, inline)]

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index b2bedfae93..487594b2d5 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -2268,11 +2268,11 @@ vc-log-internal-common
 			       setup-buttons-func
 			       goto-location-func
 			       rev-buff-func)
-  (let (retval)
-    (with-current-buffer (get-buffer-create buffer-name)
+  (let (retval (buffer (get-buffer-create buffer-name)))
+    (with-current-buffer buffer
       (set (make-local-variable 'vc-log-view-type) type))
     (setq retval (funcall backend-func backend buffer-name type files))
-    (with-current-buffer (get-buffer buffer-name)
+    (with-current-buffer buffer
       (let ((inhibit-read-only t))
 	;; log-view-mode used to be called with inhibit-read-only bound
 	;; to t, so let's keep doing it, just in case.
@@ -2283,7 +2283,7 @@ vc-log-internal-common
 	     rev-buff-func)))
     ;; Display after setting up major-mode, so display-buffer-alist can know
     ;; the major-mode.
-    (pop-to-buffer buffer-name)
+    (pop-to-buffer buffer)
     (vc-run-delayed
      (let ((inhibit-read-only t))
        (funcall setup-buttons-func backend files retval)

Message #10 received at 32475-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 32475-done <at> debbugs.gnu.org
Subject: Re: bug#32475: 27.0.50; Multiple log-view-mode buffers
Date: Fri, 31 Aug 2018 01:20:44 +0300

> To support the ability to create multiple *vc-change-log* buffers
> with customization like
>
>   (add-hook 'log-view-mode-hook 'rename-uniquely)
>
> vc-log-internal-common needs an improvement to remember and reuse
> the buffer object, instead of searching the same buffer by name:

Done in 15006cf1dd.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.