GNU bug report logs - #32392
26.1; wdired and derived dired modes

Previous Next

Package: emacs;

Reported by: James Nguyen <james <at> jojojames.com>

Date: Wed, 8 Aug 2018 02:13:02 UTC

Severity: minor

Tags: fixed

Found in version 26.1

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #15 received at 32392 <at> debbugs.gnu.org (full text, mbox):

From: james <at> jojojames.com
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 32392 <at> debbugs.gnu.org
Subject: Re: bug#32392: 26.1; wdired and derived dired modes
Date: Sun, 14 Jul 2019 20:39:50 -0700
Thanks!

> On Jul 12, 2019, at 7:58 PM, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> 
> James Nguyen <james <at> jojojames.com> writes:
> 
>> Digging into the function wdired-change-to-wdired-mode, that function
>> throws an error if the current major mode is not 'dired-mode.
>> 
>> (unless (eq major-mode 'dired-mode)
>>  (error "Not a Dired buffer"))
>> 
>> I think we can change the check to be:
>> 
>> (unless (derived-mode-p 'dired-mode)
>>  (error "Not a Dired buffer"))
> 
> Makes sense to me; I've now done this change on the Emacs trunk.
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>   bloggy blog: http://lars.ingebrigtsen.no





This bug report was last modified 5 years and 317 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.