GNU bug report logs - #32391
[PATCH] gnu: Add VBinDiff.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32391 in the body.
You can then email your comments to 32391 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add VBinDiff.
Date: Tue,  7 Aug 2018 18:36:31 -0400

I'm not sure which module to put this in!

* gnu/packages/patchutils.scm (vbindiff): New variable.
---
 gnu/packages/patchutils.scm | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm
index 224b0e8d6..55f4fd510 100644
--- a/gnu/packages/patchutils.scm
+++ b/gnu/packages/patchutils.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014 Eric Bavier <bavier <at> member.fsf.org>
-;;; Copyright © 2015 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2015, 2018 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -32,9 +32,10 @@
   #:use-module (gnu packages file)
   #:use-module (gnu packages gawk)
   #:use-module (gnu packages less)
+  #:use-module (gnu packages mail)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages python)
-  #:use-module (gnu packages mail)
   #:use-module (gnu packages xml))
 
 (define-public patchutils
@@ -209,3 +210,24 @@ list, and commands that can search that database.  It allows users to track
 the status of a patch, apply patches, and search for patches---all that from
 the command-line or from Emacs via its Notmuch integration.")
       (license gpl2+))))
+
+(define-public vbindiff
+  (package
+    (name "vbindiff")
+    (version "3.0_beta5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.cjmweb.net/vbindiff/vbindiff-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1f1kj4jki08bnrwpzi663mjfkrx4wnfpzdfwd2qgijlkx5ysjkgh"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (home-page "https://www.cjmweb.net/vbindiff/")
+    (synopsis "Console-based tool for comparing binary data")
+    (description "Visual Binary Diff (VBinDiff) displays files in hexadecimal
+and ASCII (or EBCDIC).  It can also display two files at once, and highlight the
+differences between them.  It works well with large files (up to 4 GiB).")
+    (license gpl2+)))
-- 
2.18.0

Message #8 received at 32391 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32391 <at> debbugs.gnu.org
Subject: Re: [bug#32391] [PATCH] gnu: Add VBinDiff.
Date: Thu, 9 Aug 2018 07:01:35 +0200

[Message part 1 (text/plain, inline)]

Hi Leo,

On Tue,  7 Aug 2018 18:36:31 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> I'm not sure which module to put this in!

> +++ b/gnu/packages/patchutils.scm

Sounds good, as long as we don't introduce harmful module cycles.

> +    (description "Visual Binary Diff (VBinDiff) displays files in hexadecimal
> +and ASCII (or EBCDIC).  It can also display two files at once, and highlight the
> +differences between them.  It works well with large files (up to 4 GiB).")

Maybe mention the command (@command{vbindiff}) ?

Otherwise LGTM!

I also tested it--kinda reminds me of the hex editors of old :)

[Message part 2 (application/pgp-signature, inline)]

Message #13 received at 32391-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 32391-done <at> debbugs.gnu.org
Subject: Re: [bug#32391] [PATCH] gnu: Add VBinDiff.
Date: Thu, 9 Aug 2018 08:07:53 -0400

[Message part 1 (text/plain, inline)]

On Thu, Aug 09, 2018 at 07:01:35AM +0200, Danny Milosavljevic wrote:
> Maybe mention the command (@command{vbindiff}) ?

Okay!

> Otherwise LGTM!

Thanks for the review!

> I also tested it--kinda reminds me of the hex editors of old :)

Nostalgic and useful :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.