GNU bug report logs - #32372
[PATCH] Add "uuid" to thing-at-point.el

Previous Next

Full log

Message #40 received at 32372 <at> debbugs.gnu.org (full text, mbox):

From: Raimon Grau <raimon <at> konghq.com>
To: Ivan Shmakov <ivan <at> siamics.net>, 32372 <at> debbugs.gnu.org
Cc: Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#32372: [PATCH] Add "uuid" to thing-at-point.el
Date: Thu, 09 Aug 2018 19:50:07 +0100

Ivan Shmakov <ivan <at> siamics.net> writes:

> 	While either ‘and’ or ‘if’ can be used here, to exactly the same
> 	effect, the indentation above is one for ‘if’; ‘and’ should instead
> 	look like:
>
>            (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
>                 (cons (match-beginning 0) (match-end 0)))
>
> 	I think in this case it’s marginally better to keep indentation
> 	and replace ‘and’ with ‘if’ than the other way around.

What about `when'? Is it ok to use it?

One branch 'if' look funny to me but I don't see many (any?) `when' in the emacs
codebase.

Thanks,

Raimon Grau

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.