GNU bug report logs - #32372
[PATCH] Add "uuid" to thing-at-point.el

Previous Next

Package: emacs;

Reported by: Raimon Grau <raimon <at> konghq.com>

Date: Sun, 5 Aug 2018 23:14:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ivan Shmakov <ivan <at> siamics.net>
To: 32372 <at> debbugs.gnu.org
Cc: Raimon Grau <raimon <at> konghq.com>, Noam Postavsky <npostavs <at> gmail.com>
Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el 
Date: Thu, 09 Aug 2018 18:12:54 +0000

>>>>> Raimon Grau <raimon <at> konghq.com> writes:

[…]

 > +(put 'uuid 'bounds-of-thing-at-point
 > +     (lambda ()
 > +       (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
 > +         (cons (match-beginning 0) (match-end 0)))))

	While either ‘and’ or ‘if’ can be used here, to exactly the same
	effect, the indentation above is one for ‘if’; ‘and’ should instead
	look like:

           (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
                (cons (match-beginning 0) (match-end 0)))

	I think in this case it’s marginally better to keep indentation
	and replace ‘and’ with ‘if’ than the other way around.

	Thanks.

[…]

-- 
FSF associate member #7257  http://am-1.org/~ivan/
This bug report was last modified 6 years and 278 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.