GNU bug report logs - #32372
[PATCH] Add "uuid" to thing-at-point.el

Previous Next

Package: emacs;

Reported by: Raimon Grau <raimon <at> konghq.com>

Date: Sun, 5 Aug 2018 23:14:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #16 received at 32372 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Raimon Grau <raimon <at> konghq.com>, 32372 <at> debbugs.gnu.org
Subject: Re: bug#32372: [PATCH] Add "uuid" to thing-at-point.el
Date: Mon, 06 Aug 2018 12:47:59 +0300
Noam Postavsky <npostavs <at> gmail.com> writes:

> Raimon Grau <raimon <at> konghq.com> writes:
>
>> +;; UUID
>> +
>> +(defvar thing-at-point-uuid-regexp
>> +  (rx (and bow
>
> Using rx is okay, I think.  There was some discussion about it on
> emacs-devel a little time ago, with most people saying the increased
> verbosity made them not want to use it, but I kind of like it myself.
> However, Stefan made the point that `and' is potentially a bit
> confusing, because it could be misread as intersection.  It's better to
> use one of the synonyms `seq' or `:'.

FWIW, the outer and/seq/: can be eliminated, as rx implicitly sequences
its arguments.

-- 
Basil




This bug report was last modified 6 years and 279 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.