GNU bug report logs - #32370
[PATCH 0/4] A few Ruby related patches.

Previous Next

Full log

Message #26 received at 32370 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 32370 <at> debbugs.gnu.org
Subject: Re: [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test.
Date: Tue, 7 Aug 2018 00:30:15 +0200

[Message part 1 (text/plain, inline)]

On Sun,  5 Aug 2018 15:43:22 +0100
Christopher Baines <mail <at> cbaines.net> wrote:

> From: Ben Woodcroft <donttrustben <at> gmail.com>
> 
> * gnu/packages/ruby.scm (ruby-multi-test): New variable.
> 
> Signed-off-by: Christopher Baines <mail <at> cbaines.net>
> ---
>  gnu/packages/ruby.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 888a31e89..e199d2b92 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -2304,6 +2304,32 @@ NSJSONSerialization, gson.rb, JrJackson, and
> OkJson.") (home-page "https://github.com/intridea/multi_json")
>      (license license:expat)))
>  
> +(define-public ruby-multi-test
> +  (package
> +    (name "ruby-multi-test")

Do we have name conventions for Ruby? The original name is with
underscore: multi_test, here it is written with hyphen: multi-test.


Compare: ruby-data_uri is with underscore.


It also has this strange reproducibility-problem with diffoscope
showing nothing.

Otherwise, LGTM.

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.