GNU bug report logs - #32300
Cuirass: the 'nr' filter doesn't work when builds have multiple outputs

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 32300 <at> debbugs.gnu.org
Subject: bug#32300: [PATCH] database: Fix the builds limit issue.
Date: Thu, 9 Aug 2018 07:57:09 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Sat, 04 Aug 2018 18:10:51 +0200
Clément Lassieur <clement <at> lassieur.org> wrote:

> Clément Lassieur <clement <at> lassieur.org> writes:
> 
> > Fixes <https://bugs.gnu.org/32300>.
> >
> > * src/cuirass/database.scm (filters->order): New procedure.
> > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS,
> > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures.  Remove the 'LEFT JOIN
> > Outputs' clause.  Use DB-GET-OUTPUTS for each build that was fetched.  
> 
> This may be less efficient because there are more SQL queries (one per
> output), but it's way less complicated and less buggy, so I think it's
> worth it.

Yeah, if it's still usable, I agree.

But I think we shouldn't overlook the possibility of not fetching the outputs
in the first place (at all).

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.