GNU bug report logs - #32299
[PATCH 1/7] gnu: Add volume-key.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32299 in the body.
You can then email your comments to 32299 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/7] gnu: Add volume-key.
Date: Sat, 28 Jul 2018 23:58:35 +0200

* gnu/package/disk.scm (volume-key): New variable.
---
 gnu/packages/disk.scm | 48 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index c1fc2e2c3..6d4435784 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2018 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2018 Eric Bavier <bavier <at> member.fsf.org>
 ;;; Copyright © 2018 Rutger Helling <rhelling <at> mykolab.com>
+;;; Copyright © 2018 Pierre Neidhardt <ambrevar <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -55,7 +56,11 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages vim)
   #:use-module (gnu packages w3m)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages cryptsetup)
+  #:use-module (gnu packages gnuzilla)
+  #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages swig))
 
 (define-public parted
   (package
@@ -547,3 +552,44 @@ provides a minimalistic and nice curses interface with a view on the directory
 hierarchy.  It ships with @code{rifle}, a file launcher that is good at
 automatically finding out which program to use for what file type.")
     (license license:gpl3)))
+
+(define-public volume-key
+  (package
+    (name "volume-key")
+    (version "0.3.10")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://releases.pagure.org/volume_key/volume_key-"
+                                  version ".tar.xz"))
+              (sha256
+               (base32
+                "19wqgrd0cnnjs1b1d7s9ssc957vis8vj7bls9rkwhf9ywgkrswn5"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("util-linux" ,util-linux)
+       ("glib" ,glib)
+       ("swig" ,swig)
+       ("lvm2" ,lvm2)
+       ("python" ,python-2)))           ; Used to generate the Python bindings.
+    (inputs
+     `(("cryptsetup" ,cryptsetup)
+       ("nss" ,nss)
+       ("gpgme" ,gpgme)))
+    (arguments
+     `(#:tests? #f ; Not sure how tests are supposed to pass, even when run manually.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'patch-python.h-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((python (assoc-ref inputs "python")))
+               (substitute* "Makefile.in"
+                 (("/usr/include/python") (string-append python "/include/python")))
+               #t))))))
+    (home-page "https://pagure.io/volume_key")
+    (synopsis "Manipulate storage volume encryption keys")
+    (description
+     "This package provides a library for manipulating storage volume
+encryption keys and storing them separately from volumes to handle forgotten
+passphrases.")
+    (license license:gpl2)))
-- 
2.18.0

Message #10 received at 32299-done <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 32299-done <at> debbugs.gnu.org
Subject: [PATCH 1/7] gnu: Add volume-key.
Date: Sun, 29 Jul 2018 00:02:57 +0200

[Message part 1 (text/plain, inline)]

Sorry, wrong thread, mailer mistake.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 32299 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <ambrevar <at> gmail.com>, 32299 <at> debbugs.gnu.org
Subject: Re: [bug#32299] [PATCH 1/7] gnu: Add volume-key.
Date: Mon, 30 Jul 2018 00:28:19 +0200

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> * gnu/package/disk.scm (volume-key): New variable.

[...]

> +(define-public volume-key
> +  (package
> +    (name "volume-key")
> +    (version "0.3.10")

0.3.11 is out!

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://releases.pagure.org/volume_key/volume_key-"
> +                                  version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "19wqgrd0cnnjs1b1d7s9ssc957vis8vj7bls9rkwhf9ywgkrswn5"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("util-linux" ,util-linux)
> +       ("glib" ,glib)
> +       ("swig" ,swig)
> +       ("lvm2" ,lvm2)
> +       ("python" ,python-2)))           ; Used to generate the Python bindings.

Are you sure lvm2 and glib are native-inputs?  I.e. are they truly only
needed for building, and not at runtime?

Other than that LGTM!

> +    (inputs
> +     `(("cryptsetup" ,cryptsetup)
> +       ("nss" ,nss)
> +       ("gpgme" ,gpgme)))
> +    (arguments
> +     `(#:tests? #f ; Not sure how tests are supposed to pass, even when run manually.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'patch-python.h-path
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((python (assoc-ref inputs "python")))
> +               (substitute* "Makefile.in"
> +                 (("/usr/include/python") (string-append python "/include/python")))
> +               #t))))))
> +    (home-page "https://pagure.io/volume_key")
> +    (synopsis "Manipulate storage volume encryption keys")
> +    (description
> +     "This package provides a library for manipulating storage volume
> +encryption keys and storing them separately from volumes to handle forgotten
> +passphrases.")
> +    (license license:gpl2)))
> -- 
> 2.18.0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.