GNU bug report logs - #32257
26.1; read-multiple-choice inf loops on mouse clicks

Previous Next

Full log

Message #20 received at 32257 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32257 <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton <at> gmail.com>
Subject: Re: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks
Date: Fri, 27 Jul 2018 08:45:03 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Andy Moreton <andrewjmoreton <at> gmail.com>
>> Date: Fri, 27 Jul 2018 12:35:27 +0100
>> 
>> > If we want this change on emacs-26, we should carefully audit all the
>> > other users of rmc.el

What should we check for though?

>> > (and in generally, I'd prefer some more local
>> > change in nsm.el on the release branch).  We've had our share of
>> > subtle bugs introduced by switching to an "almost-compatible" method
>> > of reading input.
>> 
>> read-multiple choice only has two callers (`nsm-query-user' and
>> `message-fix-before-sending') in both master and emacs-26.
>
> In Emacs, yes.  But what about the world out there?

I expect all the callers out in the world will exhibit the same bug.

> In case it wasn't clear I meant to make a safer change on emacs-26,
> and change read-multiple-choice on master.

At any rate, I don't see a way of fixing it in the caller, short of
temporarily fsetting read-char into read-event.  Also,
read-multiple-choice is new in Emacs 26, so it seems to me we should
rather fix it in 26.2.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.