GNU bug report logs - #32256
[PATCH] gnu: Add nudoku.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32256 in the body.
You can then email your comments to 32256 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>,
 madalinionel.patrascu <at> mdc-berlin.de
Subject: [PATCH] gnu: Add nudoku.
Date: Tue, 24 Jul 2018 14:04:02 +0200

From: Madalin Ionel-Patrascu <madalinionel.patrascu <at> mdc-berlin.de>

* gnu/packages/games.scm (nudoku): New variable.

Signed-off-by: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
---
 gnu/packages/games.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 4af0b52e8..c2e35791f 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2017, 2018 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2018 okapi <okapi <at> firemail.cc>
 ;;; Copyright © 2018 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
+;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu <at> mdc-berlin.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4714,6 +4715,25 @@ making Yamagi Quake II one of the most solid Quake II implementations available.
                     "See Info-Zip section.")
                    license:public-domain)))) ; stb
 
+(define-public nudoku
+  (package
+    (name "nudoku")
+    (version "1.0.0")
+    (source (origin
+	      (method url-fetch)
+	      (uri (string-append "https://github.com/jubalh/nudoku/"
+                                  "releases/download/" version
+                                  "/nudoku-" version ".tar.xz"))
+	      (sha256
+               (base32
+                "0nr2j2z07nxk70s8xnmmpzccxicf7kn5mbwby2kg6aq8paarjm8k"))))
+    (build-system gnu-build-system)
+    (inputs `(("ncurses" ,ncurses)))
+    (home-page "https://jubalh.github.io/nudoku/")
+    (synopsis "Sudoku for your terminal")
+    (description "nudoku is a ncurses based sudoku game.")
+    (license license:gpl3+)))
+
 (define-public the-butterfly-effect
   (package
     (name "the-butterfly-effect")
-- 
2.18.0

Message #8 received at 32256 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: 32256 <at> debbugs.gnu.org, madalinionel.patrascu <at> mdc-berlin.de
Subject: Re: [bug#32256] [PATCH] gnu: Add nudoku.
Date: Thu, 26 Jul 2018 16:15:27 -0400

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de> writes:

> From: Madalin Ionel-Patrascu <madalinionel.patrascu <at> mdc-berlin.de>
>
> * gnu/packages/games.scm (nudoku): New variable.
>
> Signed-off-by: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
> ---
>  gnu/packages/games.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 4af0b52e8..c2e35791f 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -33,6 +33,7 @@
>  ;;; Copyright © 2017, 2018 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
>  ;;; Copyright © 2018 okapi <okapi <at> firemail.cc>
>  ;;; Copyright © 2018 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> +;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu <at> mdc-berlin.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4714,6 +4715,25 @@ making Yamagi Quake II one of the most solid Quake II implementations available.
>                      "See Info-Zip section.")
>                     license:public-domain)))) ; stb
>  
> +(define-public nudoku
> +  (package
> +    (name "nudoku")
> +    (version "1.0.0")
> +    (source (origin
> +	      (method url-fetch)
> +	      (uri (string-append "https://github.com/jubalh/nudoku/"
> +                                  "releases/download/" version
> +                                  "/nudoku-" version ".tar.xz"))
> +	      (sha256
> +               (base32
> +                "0nr2j2z07nxk70s8xnmmpzccxicf7kn5mbwby2kg6aq8paarjm8k"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "https://jubalh.github.io/nudoku/")
> +    (synopsis "Sudoku for your terminal")
> +    (description "nudoku is a ncurses based sudoku game.")

I'd use "@code{nudoku}" here because it's the name of a program.

> +    (license license:gpl3+)))
> +
>  (define-public the-butterfly-effect
>    (package
>      (name "the-butterfly-effect")

Otherwise this looks fine and works well for me!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 32256-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: madalinionel.patrascu <at> mdc-berlin.de, 32256-done <at> debbugs.gnu.org
Subject: Re: [bug#32256] [PATCH] gnu: Add nudoku.
Date: Thu, 16 Aug 2018 17:07:55 +0200

Hi Kei,

> Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de> writes:
>
>> From: Madalin Ionel-Patrascu <madalinionel.patrascu <at> mdc-berlin.de>
>>
>> * gnu/packages/games.scm (nudoku): New variable.
>>
>> Signed-off-by: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
>> ---
[…]
>> +    (description "nudoku is a ncurses based sudoku game.")
>
> I'd use "@code{nudoku}" here because it's the name of a program.
>
>> +    (license license:gpl3+)))
>> +
>>  (define-public the-butterfly-effect
>>    (package
>>      (name "the-butterfly-effect")
>
> Otherwise this looks fine and works well for me!

Thanks for your input.  I changed the description, but ended up not
using @code{} here.

-- 
Ricardo

Message #16 received at 32256 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 32256 <at> debbugs.gnu.org
Subject: Re: [bug#32256] [PATCH] gnu: Add nudoku.
Date: Thu, 16 Aug 2018 18:45:11 +0200

Kei,

Just an aside on this important matter.

Kei Kebreau wrote:
>> +    (description "nudoku is a ncurses based sudoku game.")
>
> I'd use "@code{nudoku}" here because it's the name of a program.

While there's some precedent in Guix for using @code{} for marking 
up package names when they'll be used mainly in actual source code 
(e.g. @code{My::Perl::Module}), that's a specific case with a 
specific rationale.

A more suitable tag here would be @command{}. However, there seems 
to be an informal(?) consensus not to use it when talking about 
the package as a whole/project, but only when referring to the 
actual command (binary) itself. Some descriptions don't follow 
that convention, though, so it's at best a grey area.

I don't think programme names should be marked up all purdy just 
for being programmes.

Kind regards,

T G-R

Message #19 received at 32256 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 32256 <at> debbugs.gnu.org
Subject: Re: [bug#32256] [PATCH] gnu: Add nudoku.
Date: Fri, 17 Aug 2018 03:44:13 -0400

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Kei,
>
> Just an aside on this important matter.
>
> Kei Kebreau wrote:
>>> +    (description "nudoku is a ncurses based sudoku game.")
>>
>> I'd use "@code{nudoku}" here because it's the name of a program.
>
> While there's some precedent in Guix for using @code{} for marking up
> package names when they'll be used mainly in actual source code
> (e.g. @code{My::Perl::Module}), that's a specific case with a specific
> rationale.
>
> A more suitable tag here would be @command{}. However, there seems to
> be an informal(?) consensus not to use it when talking about the
> package as a whole/project, but only when referring to the actual
> command (binary) itself. Some descriptions don't follow that
> convention, though, so it's at best a grey area.
>
> I don't think programme names should be marked up all purdy just for
> being programmes.
>
> Kind regards,
>
> T G-R

Alright. Hopefully I'll pick up more on these hints as I read more
documentation source code.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.