GNU bug report logs - #32048
Remove redundant value checks

Previous Next

Full log

View this message in rfc822 format

From: Fritz Stelzer <brotzeitmacher <at> gmail.com>
To: 32048 <at> debbugs.gnu.org
Subject: bug#32048: Remove redundant value checks
Date: Wed, 4 Jul 2018 13:59:37 +0200

[Message part 1 (text/plain, inline)]

These checks are done in pset_filter and pset_sentinel.

master 05c42757da95e2697c08ce54f91b07649a431408
Author:     brotzeit <brotzeitmacher <at> gmail.com>
AuthorDate: Wed Jul 4 14:55:02 2018 +0200
Commit:     brotzeit <brotzeitmacher <at> gmail.com>
CommitDate: Wed Jul 4 14:55:02 2018 +0200

Parent:     3bbd4ffc68 * lisp/shell.el (shell-completion-vars):
Merged:     master
Containing: master
Follows:    emacs-26.1 (2428)

Remove redundant NILP calls

1 file changed, 6 deletions(-)
src/process.c | 6 ------

modified   src/process.c
@@ -1274,9 +1274,6 @@ The string argument is normally a multibyte string,
except:
      (debug)
      (set-process-filter process ...)  */

-  if (NILP (filter))
-    filter = Qinternal_default_process_filter;
-
   pset_filter (p, filter);

   if (p->infd >= 0)
@@ -1310,9 +1307,6 @@ It gets two arguments: the process, and a string
describing the change.  */)
   CHECK_PROCESS (process);
   p = XPROCESS (process);

-  if (NILP (sentinel))
-    sentinel = Qinternal_default_process_sentinel;
-
   pset_sentinel (p, sentinel);
   if (NETCONN1_P (p) || SERIALCONN1_P (p) || PIPECONN1_P (p))
     pset_childp (p, Fplist_put (p->childp, QCsentinel, sentinel));

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.