GNU bug report logs - #32048
Remove redundant value checks

Previous Next

Package: emacs;

Reported by: Fritz Stelzer <brotzeitmacher <at> gmail.com>

Date: Wed, 4 Jul 2018 12:00:02 UTC

Severity: normal

Tags: notabug, wontfix

Merged with 32049

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32048 in the body.
You can then email your comments to 32048 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#32048; Package emacs. (Wed, 04 Jul 2018 12:00:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Fritz Stelzer <brotzeitmacher <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 04 Jul 2018 12:00:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fritz Stelzer <brotzeitmacher <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Remove redundant value checks
Date: Wed, 4 Jul 2018 13:59:37 +0200

[Message part 1 (text/plain, inline)]
These checks are done in pset_filter and pset_sentinel.

master 05c42757da95e2697c08ce54f91b07649a431408
Author:     brotzeit <brotzeitmacher <at> gmail.com>
AuthorDate: Wed Jul 4 14:55:02 2018 +0200
Commit:     brotzeit <brotzeitmacher <at> gmail.com>
CommitDate: Wed Jul 4 14:55:02 2018 +0200

Parent:     3bbd4ffc68 * lisp/shell.el (shell-completion-vars):
Merged:     master
Containing: master
Follows:    emacs-26.1 (2428)

Remove redundant NILP calls

1 file changed, 6 deletions(-)
src/process.c | 6 ------

modified   src/process.c
@@ -1274,9 +1274,6 @@ The string argument is normally a multibyte string,
except:
      (debug)
      (set-process-filter process ...)  */

-  if (NILP (filter))
-    filter = Qinternal_default_process_filter;
-
   pset_filter (p, filter);

   if (p->infd >= 0)
@@ -1310,9 +1307,6 @@ It gets two arguments: the process, and a string
describing the change.  */)
   CHECK_PROCESS (process);
   p = XPROCESS (process);

-  if (NILP (sentinel))
-    sentinel = Qinternal_default_process_sentinel;
-
   pset_sentinel (p, sentinel);
   if (NETCONN1_P (p) || SERIALCONN1_P (p) || PIPECONN1_P (p))
     pset_childp (p, Fplist_put (p->childp, QCsentinel, sentinel));

[Message part 2 (text/html, inline)]
Merged 32048 32049. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 04 Jul 2018 12:15:02 GMT) Full text and rfc822 format available.
Added tag(s) notabug and wontfix. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 04 Jul 2018 12:15:02 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 32049 <at> debbugs.gnu.org and Fritz Stelzer <brotzeitmacher <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 04 Jul 2018 12:15:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 02 Aug 2018 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 323 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.