GNU bug report logs - #32021
hexl-follow-ascii-mode is not initialized

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32021: closed (hexl-follow-ascii-mode is not initialized)
Date: Sat, 30 Jun 2018 18:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 30 Jun 2018 21:00:45 +0300
with message-id <83y3ewkvci.fsf <at> gnu.org>
and subject line Re: bug#32021: hexl-follow-ascii-mode is not initialized
has caused the debbugs.gnu.org bug report #32021,
regarding hexl-follow-ascii-mode is not initialized
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32021: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32021
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Shuguang" <shuguang79 <at> qq.com>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Subject: hexl-follow-ascii-mode is not initialized
Date: Sun, 1 Jul 2018 01:07:47 +0800

[Message part 3 (text/plain, inline)]

Hi,


Windows 7
Emacs git master/2018.6.24 at least


When I try to toggle hexl-mode, it reports
"defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".


It looks like the definiation of hexl-follow-ascii-mode is incorect.


From the doc of define-minor-mode, it requires INIT-VALUE LIGHTER KEYMAP or at least one keyword argument. 

According to the DOC of hexl-follow-ascii-mode, I think the following patch should be proper.


diff --git a/lisp/hexl.el b/lisp/hexl.el
index f37be9d410..6b316dd707 100644
--- a/lisp/hexl.el
+++ b/lisp/hexl.el
@@ -1000,6 +1000,7 @@ hexl-follow-ascii-mode
 When following is enabled, the ASCII character corresponding to the
 element under the point is highlighted.
 The default activation is controlled by `hexl-follow-ascii'."
+  :init-value hexl-follow-ascii
   (if hexl-follow-ascii-mode
       ;; turn it on
       (progn



Best Regards,
Shuguang Sun

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Shuguang" <shuguang79 <at> qq.com>
Cc: 32021-done <at> debbugs.gnu.org
Subject: Re: bug#32021: hexl-follow-ascii-mode is not initialized
Date: Sat, 30 Jun 2018 21:00:45 +0300

> From: "Shuguang" <shuguang79 <at> qq.com>
> Date: Sun, 1 Jul 2018 01:07:47 +0800
> 
> Windows 7
> Emacs git master/2018.6.24 at least
> 
> When I try to toggle hexl-mode, it reports
> "defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".

Thanks, fixed.

> It looks like the definiation of hexl-follow-ascii-mode is incorect.

No, it was a typo in hexl-follow-ascii-mode.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.