GNU bug report logs - #32021
hexl-follow-ascii-mode is not initialized

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32021 in the body.
You can then email your comments to 32021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Shuguang" <shuguang79 <at> qq.com>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Subject: hexl-follow-ascii-mode is not initialized
Date: Sun, 1 Jul 2018 01:07:47 +0800

[Message part 1 (text/plain, inline)]

Hi,


Windows 7
Emacs git master/2018.6.24 at least


When I try to toggle hexl-mode, it reports
"defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".


It looks like the definiation of hexl-follow-ascii-mode is incorect.


From the doc of define-minor-mode, it requires INIT-VALUE LIGHTER KEYMAP or at least one keyword argument. 

According to the DOC of hexl-follow-ascii-mode, I think the following patch should be proper.


diff --git a/lisp/hexl.el b/lisp/hexl.el
index f37be9d410..6b316dd707 100644
--- a/lisp/hexl.el
+++ b/lisp/hexl.el
@@ -1000,6 +1000,7 @@ hexl-follow-ascii-mode
 When following is enabled, the ASCII character corresponding to the
 element under the point is highlighted.
 The default activation is controlled by `hexl-follow-ascii'."
+  :init-value hexl-follow-ascii
   (if hexl-follow-ascii-mode
       ;; turn it on
       (progn



Best Regards,
Shuguang Sun

[Message part 2 (text/html, inline)]

Message #10 received at 32021-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Shuguang" <shuguang79 <at> qq.com>
Cc: 32021-done <at> debbugs.gnu.org
Subject: Re: bug#32021: hexl-follow-ascii-mode is not initialized
Date: Sat, 30 Jun 2018 21:00:45 +0300

> From: "Shuguang" <shuguang79 <at> qq.com>
> Date: Sun, 1 Jul 2018 01:07:47 +0800
> 
> Windows 7
> Emacs git master/2018.6.24 at least
> 
> When I try to toggle hexl-mode, it reports
> "defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".

Thanks, fixed.

> It looks like the definiation of hexl-follow-ascii-mode is incorect.

No, it was a typo in hexl-follow-ascii-mode.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.