GNU bug report logs - #32017
import: elpa: Check if 'fetch-elpa-package' rest argument is null.

Previous Next

Full log

Message #8 received at 32017 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32017 <at> debbugs.gnu.org
Subject: Re: [bug#32017] import: elpa: Check if 'fetch-elpa-package' rest
 argument is null.
Date: Mon, 02 Jul 2018 17:43:20 +0200

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From 5b06ab52ada54fc4c42c87400a7b635843cf1542 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sat, 30 Jun 2018 10:51:45 +0300
> Subject: [PATCH] import: elpa: Check if 'fetch-elpa-package' rest argument is
>  null.
>
> * guix/import/elpa.scm (fetch-elpa-package): Check if 'rest' is null.
> ---
>  guix/import/elpa.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
> index 65e0be45a..869e70ee2 100644
> --- a/guix/import/elpa.scm
> +++ b/guix/import/elpa.scm
> @@ -187,7 +187,7 @@ include VERSION."
>               (url (package-source-url kind name ver repo)))
>           (make-elpa-package name ver
>                              (ensure-list reqs) synopsis kind
> -                            (package-home-page (first rest))
> +                            (package-home-page (if (null? rest) #f (first rest)))
>                              (fetch-package-description kind name repo)

As per our coding style guidelines (info "(guix) Data Types and Pattern
Matching"), it would be best to write:

  (match rest
    (() #f)
    ((one) one))

Otherwise LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.