GNU bug report logs - #32017
import: elpa: Check if 'fetch-elpa-package' rest argument is null.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32017 in the body.
You can then email your comments to 32017 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: import: elpa: Check if 'fetch-elpa-package' rest argument is null.
Date: Sat, 30 Jun 2018 10:55:05 +0300

[Message part 1 (text/plain, inline)]

Hello Guix,

This patch fixes the following error:
--8<---------------cut here---------------start------------->8---
$ guix import elpa -a melpa proc-net
Backtrace:
           6 (primitive-load "/home/natsu/.config/guix/current/bin/guix")
In guix/ui.scm:
  1570:12  5 (run-guix-command _ . _)
In guix/scripts/import.scm:
   114:11  4 (guix-import . _)
In guix/scripts/import/elpa.scm:
   108:23  3 (guix-import-elpa . _)
In guix/import/elpa.scm:
    247:2  2 (elpa->guix-package _ _)
   190:47  1 (fetch-elpa-package _ _)
In unknown file:
           0 (car ())

ERROR: In procedure car:
In procedure car: Wrong type (expecting pair): ()
--8<---------------cut here---------------end--------------->8---

[0001-import-elpa-Check-if-fetch-elpa-package-rest-argumen.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 32017 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32017 <at> debbugs.gnu.org
Subject: Re: [bug#32017] import: elpa: Check if 'fetch-elpa-package' rest
 argument is null.
Date: Mon, 02 Jul 2018 17:43:20 +0200

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From 5b06ab52ada54fc4c42c87400a7b635843cf1542 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sat, 30 Jun 2018 10:51:45 +0300
> Subject: [PATCH] import: elpa: Check if 'fetch-elpa-package' rest argument is
>  null.
>
> * guix/import/elpa.scm (fetch-elpa-package): Check if 'rest' is null.
> ---
>  guix/import/elpa.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
> index 65e0be45a..869e70ee2 100644
> --- a/guix/import/elpa.scm
> +++ b/guix/import/elpa.scm
> @@ -187,7 +187,7 @@ include VERSION."
>               (url (package-source-url kind name ver repo)))
>           (make-elpa-package name ver
>                              (ensure-list reqs) synopsis kind
> -                            (package-home-page (first rest))
> +                            (package-home-page (if (null? rest) #f (first rest)))
>                              (fetch-package-description kind name repo)

As per our coding style guidelines (info "(guix) Data Types and Pattern
Matching"), it would be best to write:

  (match rest
    (() #f)
    ((one) one))

Otherwise LGTM, thanks!

Ludo’.

Message #11 received at 32017 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32017-done <at> debbugs.gnu.org, 32017 <at> debbugs.gnu.org
Subject: Re: [bug#32017] import: elpa: Check if 'fetch-elpa-package' rest
 argument is null.
Date: Tue, 03 Jul 2018 07:23:28 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Thank you for review and improvements.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> From 5b06ab52ada54fc4c42c87400a7b635843cf1542 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Sat, 30 Jun 2018 10:51:45 +0300
>> Subject: [PATCH] import: elpa: Check if 'fetch-elpa-package' rest argument is
>>  null.
>>
>> * guix/import/elpa.scm (fetch-elpa-package): Check if 'rest' is null.
>> ---
>>  guix/import/elpa.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
>> index 65e0be45a..869e70ee2 100644
>> --- a/guix/import/elpa.scm
>> +++ b/guix/import/elpa.scm
>> @@ -187,7 +187,7 @@ include VERSION."
>>               (url (package-source-url kind name ver repo)))
>>           (make-elpa-package name ver
>>                              (ensure-list reqs) synopsis kind
>> -                            (package-home-page (first rest))
>> +                            (package-home-page (if (null? rest) #f (first rest)))
>>                              (fetch-package-description kind name repo)
>
> As per our coding style guidelines (info "(guix) Data Types and Pattern
> Matching"), it would be best to write:
>
>   (match rest
>     (() #f)
>     ((one) one))
>
> Otherwise LGTM, thanks!

OK, pushed as ae6fa00af02399e2ffadccc81bd7718cc7c26f10

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.