GNU bug report logs - #32
Bug in etags ".." code

Previous Next

Package: emacs;

Reported by: Tom Tromey <tromey <at> redhat.com>

Date: Mon, 3 Mar 2008 03:20:04 UTC

Severity: normal

Tags: patch

Merged with 735

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32 in the body.
You can then email your comments to 32 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#32; Package emacs. Full text and rfc822 format available.
Acknowledgement sent to Tom Tromey <tromey <at> redhat.com>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Tom Tromey <tromey <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Bug in etags ".." code
Date: Sun, 02 Mar 2008 17:02:48 -0700

I ran etags like this:

etags ./eval.c -o $(pwd)//.retags.d/Q

Note the double "/".

The resulting tags file contains this line:

../../eval.c,567

But this is wrong, there should be only a single "..".

I think relative_filename needs to handle the situation where multiple
"/"s appear consecutively.  The appended patch worked for me.

Tom

*** etags.c	07 Feb 2008 19:34:52 -0700	3.82
--- etags.c	02 Mar 2008 17:01:30 -0700	
***************
*** 6792,6799 ****
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     i += 1;
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)
--- 6792,6805 ----
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
+   while (*dp == '/')
+     ++dp;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     {
!       i += 1;
!       while (*dp == '/')
! 	++dp;
!     }
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)
Owner recorded as Francesco Potorti <pot <at> gnu.org>. Request was from Stefan Monnier <monnier <at> iro.umontreal.ca> to control <at> emacsbugs.donarmstrong.com. (Wed, 19 Mar 2008 18:30:04 GMT) Full text and rfc822 format available.
Tags added: patch Request was from Stefan Monnier <monnier <at> iro.umontreal.ca> to control <at> emacsbugs.donarmstrong.com. (Wed, 23 Apr 2008 21:40:05 GMT) Full text and rfc822 format available.
Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. Full text and rfc822 format available.
Notification sent to Tom Tromey <tromey <at> redhat.com>:
bug acknowledged by developer. Full text and rfc822 format available.

Message #14 received at 32-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 32-done <at> debbugs.gnu.org
Subject: Re: Bug in etags ".." code
Date: Thu, 29 May 2008 16:18:48 -0400

Thanks, installed,


        Stefan
bug archived. Request was from Debbugs Internal Request <don <at> donarmstrong.com> to internal_control <at> emacsbugs.donarmstrong.com. (Fri, 27 Jun 2008 14:24:04 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2010 22:49:01 GMT) Full text and rfc822 format available.
Removed annotation that bug was owned by Francesco Potorti <pot <at> gnu.org>. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2010 22:52:01 GMT) Full text and rfc822 format available.
Merged 32 735. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2010 22:52:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <bug-gnu-emacs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 18 Feb 2010 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 184 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.