GNU bug report logs -
#31969
[PATCH] bootloader: grub-efi: Identify as "GuixSD" instead of "grub".
Previous Next
Reported by: Marius Bakke <mbakke <at> fastmail.com>
Date: Mon, 25 Jun 2018 20:51:02 UTC
Severity: normal
Tags: patch
Done: Marius Bakke <mbakke <at> fastmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#31969: [PATCH] bootloader: grub-efi: Identify as "GuixSD" instead of "grub".
which was filed against the guix-patches package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 31969 <at> debbugs.gnu.org.
--
31969: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31969
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
[Message part 3 (text/plain, inline)]
ludo <at> gnu.org (Ludovic Courtès) writes:
> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> * gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to grub-install.
>> ---
>> gnu/bootloader/grub.scm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
>> index 8f45995ca..538ddc37a 100644
>> --- a/gnu/bootloader/grub.scm
>> +++ b/gnu/bootloader/grub.scm
>> @@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%")
>> ;; root partition.
>> (setenv "GRUB_ENABLE_CRYPTODISK" "y")
>> (unless (zero? (system* grub-install "--boot-directory" install-dir
>> + "--bootloader-id=GuixSD"
>
> What does it do? I can’t even find it in the manual.
UEFI firmwares contain a list of boot entries that looks roughly like
"foo: uuid,partnum,/path/to/loader". Try `efibootmgr -v` on an EFI
system for a more practical example.
If nothing is specified, GRUB will identify as "grub". With this patch,
when you look through the possible boot entries in UEFI, there will be
no doubt which one is GuixSD :-)
However there is one other practical consequence: the GRUB EFI blob will
now be installed to "/boot/efi/EFI/GuixSD/grubx64.efi". So current UEFI
GuixSD users will have a stale "/boot/efi/EFI/grub" folder that is no
longer needed.
> Otherwise no objections from me.
Great, I'll push this shortly.
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
* gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to grub-install.
---
gnu/bootloader/grub.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index 8f45995ca..538ddc37a 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%")
;; root partition.
(setenv "GRUB_ENABLE_CRYPTODISK" "y")
(unless (zero? (system* grub-install "--boot-directory" install-dir
+ "--bootloader-id=GuixSD"
"--efi-directory" target-esp))
(error "failed to install GRUB (EFI)")))))
--
2.18.0
This bug report was last modified 6 years and 333 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.