GNU bug report logs - #31969
[PATCH] bootloader: grub-efi: Identify as "GuixSD" instead of "grub".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31969 in the body.
You can then email your comments to 31969 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH] bootloader: grub-efi: Identify as "GuixSD" instead of "grub".
Date: Mon, 25 Jun 2018 22:50:15 +0200

* gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to grub-install.
---
 gnu/bootloader/grub.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index 8f45995ca..538ddc37a 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%")
         ;; root partition.
         (setenv "GRUB_ENABLE_CRYPTODISK" "y")
         (unless (zero? (system* grub-install "--boot-directory" install-dir
+                                "--bootloader-id=GuixSD"
                                 "--efi-directory" target-esp))
           (error "failed to install GRUB (EFI)")))))
 
-- 
2.18.0

Message #8 received at 31969 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31969 <at> debbugs.gnu.org
Subject: Re: [bug#31969] [PATCH] bootloader: grub-efi: Identify as "GuixSD"
 instead of "grub".
Date: Tue, 26 Jun 2018 16:04:13 +0200

Marius Bakke <mbakke <at> fastmail.com> skribis:

> * gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to grub-install.
> ---
>  gnu/bootloader/grub.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
> index 8f45995ca..538ddc37a 100644
> --- a/gnu/bootloader/grub.scm
> +++ b/gnu/bootloader/grub.scm
> @@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%")
>          ;; root partition.
>          (setenv "GRUB_ENABLE_CRYPTODISK" "y")
>          (unless (zero? (system* grub-install "--boot-directory" install-dir
> +                                "--bootloader-id=GuixSD"

What does it do?  I can’t even find it in the manual.

Otherwise no objections from me.

Ludo’.

Message #13 received at 31969-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31969-done <at> debbugs.gnu.org
Subject: Re: [bug#31969] [PATCH] bootloader: grub-efi: Identify as "GuixSD"
 instead of "grub".
Date: Tue, 26 Jun 2018 17:05:42 +0200

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> * gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to grub-install.
>> ---
>>  gnu/bootloader/grub.scm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
>> index 8f45995ca..538ddc37a 100644
>> --- a/gnu/bootloader/grub.scm
>> +++ b/gnu/bootloader/grub.scm
>> @@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%")
>>          ;; root partition.
>>          (setenv "GRUB_ENABLE_CRYPTODISK" "y")
>>          (unless (zero? (system* grub-install "--boot-directory" install-dir
>> +                                "--bootloader-id=GuixSD"
>
> What does it do?  I can’t even find it in the manual.

UEFI firmwares contain a list of boot entries that looks roughly like
"foo: uuid,partnum,/path/to/loader".  Try `efibootmgr -v` on an EFI
system for a more practical example.

If nothing is specified, GRUB will identify as "grub".  With this patch,
when you look through the possible boot entries in UEFI, there will be
no doubt which one is GuixSD :-)

However there is one other practical consequence: the GRUB EFI blob will
now be installed to "/boot/efi/EFI/GuixSD/grubx64.efi".  So current UEFI
GuixSD users will have a stale "/boot/efi/EFI/grub" folder that is no
longer needed.

> Otherwise no objections from me.

Great, I'll push this shortly.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 31969-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31969-done <at> debbugs.gnu.org
Subject: Re: [bug#31969] [PATCH] bootloader: grub-efi: Identify as "GuixSD"
 instead of "grub".
Date: Tue, 26 Jun 2018 22:12:36 +0200

Marius Bakke <mbakke <at> fastmail.com> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Marius Bakke <mbakke <at> fastmail.com> skribis:
>>
>>> * gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to grub-install.
>>> ---
>>>  gnu/bootloader/grub.scm | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
>>> index 8f45995ca..538ddc37a 100644
>>> --- a/gnu/bootloader/grub.scm
>>> +++ b/gnu/bootloader/grub.scm
>>> @@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%")
>>>          ;; root partition.
>>>          (setenv "GRUB_ENABLE_CRYPTODISK" "y")
>>>          (unless (zero? (system* grub-install "--boot-directory" install-dir
>>> +                                "--bootloader-id=GuixSD"
>>
>> What does it do?  I can’t even find it in the manual.
>
> UEFI firmwares contain a list of boot entries that looks roughly like
> "foo: uuid,partnum,/path/to/loader".  Try `efibootmgr -v` on an EFI
> system for a more practical example.
>
> If nothing is specified, GRUB will identify as "grub".  With this patch,
> when you look through the possible boot entries in UEFI, there will be
> no doubt which one is GuixSD :-)
>
> However there is one other practical consequence: the GRUB EFI blob will
> now be installed to "/boot/efi/EFI/GuixSD/grubx64.efi".  So current UEFI
> GuixSD users will have a stale "/boot/efi/EFI/grub" folder that is no
> longer needed.

Oh, I see now.  Thanks for explaining!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.